Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1513783
| From | Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/2] tpm/tpm-interface: place kdoc just above tpm_pcr_extend |
| Date | 2016-11-02 11:10 +0100 |
| Message-ID | <sz0Ey-4RY-7@gated-at.bofh.it> (permalink) |
| References | <syuOm-155-5@gated-at.bofh.it> <syuOm-155-3@gated-at.bofh.it> |
| Organization | Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo |
On Tue, Nov 01, 2016 at 03:05:13AM +0200, Tomas Winkler wrote:
> Place kdoc just above tpm_pcr_extend so it can be parsed
> correctly.
>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
/Jarkko
> ---
> drivers/char/tpm/tpm-interface.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-interface.c
> index cb0e57ee053d..d496a6b26a45 100644
> --- a/drivers/char/tpm/tpm-interface.c
> +++ b/drivers/char/tpm/tpm-interface.c
> @@ -731,6 +731,14 @@ int tpm_pcr_read(u32 chip_num, int pcr_idx, u8 *res_buf)
> }
> EXPORT_SYMBOL_GPL(tpm_pcr_read);
>
> +#define TPM_ORD_PCR_EXTEND cpu_to_be32(20)
> +#define EXTEND_PCR_RESULT_SIZE 34
> +static const struct tpm_input_header pcrextend_header = {
> + .tag = TPM_TAG_RQU_COMMAND,
> + .length = cpu_to_be32(34),
> + .ordinal = TPM_ORD_PCR_EXTEND
> +};
> +
> /**
> * tpm_pcr_extend - extend pcr value with hash
> * @chip_num: tpm idx # or AN&
> @@ -741,14 +749,6 @@ EXPORT_SYMBOL_GPL(tpm_pcr_read);
> * isn't, protect against the chip disappearing, by incrementing
> * the module usage count.
> */
> -#define TPM_ORD_PCR_EXTEND cpu_to_be32(20)
> -#define EXTEND_PCR_RESULT_SIZE 34
> -static const struct tpm_input_header pcrextend_header = {
> - .tag = TPM_TAG_RQU_COMMAND,
> - .length = cpu_to_be32(34),
> - .ordinal = TPM_ORD_PCR_EXTEND
> -};
> -
> int tpm_pcr_extend(u32 chip_num, int pcr_idx, const u8 *hash)
> {
> struct tpm_cmd_t cmd;
> --
> 2.7.4
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/2] tpm/tpm-interface: place kdoc just above tpm_pcr_extend Tomas Winkler <tomas.winkler@intel.com> - 2016-11-01 01:10 +0100
Re: [PATCH 1/2] tpm/tpm-interface: place kdoc just above tpm_pcr_extend Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-11-02 11:10 +0100
Re: [PATCH 1/2] tpm/tpm-interface: place kdoc just above tpm_pcr_extend Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-11-04 06:30 +0100
csiph-web