Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1510933 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2016-10-28 10:20 +0200 |
| Last post | 2016-10-29 10:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] pinctrl: max77620: add OF dependency Arnd Bergmann <arnd@arndb.de> - 2016-10-28 10:20 +0200
Re: [PATCH] pinctrl: max77620: add OF dependency Linus Walleij <linus.walleij@linaro.org> - 2016-10-29 10:40 +0200
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-10-28 10:20 +0200 |
| Subject | [PATCH] pinctrl: max77620: add OF dependency |
| Message-ID | <sxayl-5Mi-9@gated-at.bofh.it> |
Drivers using pinconf_generic_params tables cannot be built with
CONFIG_OF disabled:
drivers/pinctrl/pinctrl-max77620.c:53:44: error: array type has incomplete element type ‘struct pinconf_generic_params’
drivers/pinctrl/pinctrl-max77620.c:55:3: error: field name not in record or union initializer
drivers/pinctrl/pinctrl-max77620.c:55:3: note: (near initialization for ‘max77620_cfg_params’)
drivers/pinctrl/pinctrl-max77620.c:56:3: error: field name not in record or union initializer
This adds a dependency for max77620 to disallow that configuration.
Alternatively, we could rework the pinctrl infrastructure to make the
configuration valid for compile-testing.
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Lee Jones <lee.jones@linaro.org>
Fixes: 453943dc8f45 ("mfd: Enable compile testing for max77620 and max77686")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/pinctrl/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 801fa8bb05e1..3eea73937ce8 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -223,7 +223,7 @@ config PINCTRL_COH901
config PINCTRL_MAX77620
tristate "MAX77620/MAX20024 Pincontrol support"
- depends on MFD_MAX77620
+ depends on MFD_MAX77620 && OF
select PINMUX
select GENERIC_PINCONF
help
--
2.9.0
[toc] | [next] | [standalone]
| From | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| Date | 2016-10-29 10:40 +0200 |
| Message-ID | <sxxlf-3Nw-5@gated-at.bofh.it> |
| In reply to | #1510933 |
On Fri, Oct 28, 2016 at 10:19 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> Drivers using pinconf_generic_params tables cannot be built with
> CONFIG_OF disabled:
>
> drivers/pinctrl/pinctrl-max77620.c:53:44: error: array type has incomplete element type ‘struct pinconf_generic_params’
> drivers/pinctrl/pinctrl-max77620.c:55:3: error: field name not in record or union initializer
> drivers/pinctrl/pinctrl-max77620.c:55:3: note: (near initialization for ‘max77620_cfg_params’)
> drivers/pinctrl/pinctrl-max77620.c:56:3: error: field name not in record or union initializer
>
> This adds a dependency for max77620 to disallow that configuration.
>
> Alternatively, we could rework the pinctrl infrastructure to make the
> configuration valid for compile-testing.
>
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> Cc: Lee Jones <lee.jones@linaro.org>
> Fixes: 453943dc8f45 ("mfd: Enable compile testing for max77620 and max77686")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Patch applied.
Yours,
Linus Walleij
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web