Re: [PATCH] pinctrl: max77620: add OF dependency

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] pinctrl: max77620: add OF dependency
Date	2016-10-29 10:40 +0200
Message-ID	<sxxlf-3Nw-5@gated-at.bofh.it> (permalink)
References	<sxayl-5Mi-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Oct 28, 2016 at 10:19 AM, Arnd Bergmann <arnd@arndb.de> wrote:

> Drivers using pinconf_generic_params tables cannot be built with
> CONFIG_OF disabled:
>
> drivers/pinctrl/pinctrl-max77620.c:53:44: error: array type has incomplete element type ‘struct pinconf_generic_params’
> drivers/pinctrl/pinctrl-max77620.c:55:3: error: field name not in record or union initializer
> drivers/pinctrl/pinctrl-max77620.c:55:3: note: (near initialization for ‘max77620_cfg_params’)
> drivers/pinctrl/pinctrl-max77620.c:56:3: error: field name not in record or union initializer
>
> This adds a dependency for max77620 to disallow that configuration.
>
> Alternatively, we could rework the pinctrl infrastructure to make the
> configuration valid for compile-testing.
>
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> Cc: Lee Jones <lee.jones@linaro.org>
> Fixes: 453943dc8f45 ("mfd: Enable compile testing for max77620 and max77686")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Patch applied.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] pinctrl: max77620: add OF dependency Arnd Bergmann <arnd@arndb.de> - 2016-10-28 10:20 +0200
  Re: [PATCH] pinctrl: max77620: add OF dependency Linus Walleij <linus.walleij@linaro.org> - 2016-10-29 10:40 +0200

csiph-web