Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1509483 > unrolled thread
| Started by | Felix Brack <fb@ltec.ch> |
|---|---|
| First post | 2016-10-26 16:40 +0200 |
| Last post | 2016-10-26 16:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] led: pca9532: Use default trigger value from platform data Felix Brack <fb@ltec.ch> - 2016-10-26 16:40 +0200
Re: [PATCH] led: pca9532: Use default trigger value from platform data Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-10-26 16:50 +0200
| From | Felix Brack <fb@ltec.ch> |
|---|---|
| Date | 2016-10-26 16:40 +0200 |
| Subject | [PATCH] led: pca9532: Use default trigger value from platform data |
| Message-ID | <swxwZ-4Y6-5@gated-at.bofh.it> |
The value for a led's default_trigger should come from platform data instead of data (which is always 0). Signed-off-by: Felix Brack <fb@ltec.ch> --- diff --git a/drivers/leds/leds-pca9532.c b/drivers/leds/leds-pca9532.c index 09a7cffb..06e6310 100644 --- a/drivers/leds/leds-pca9532.c +++ b/drivers/leds/leds-pca9532.c @@ -369,7 +369,7 @@ static int pca9532_configure(struct i2c_client *client, led->state = pled->state; led->name = pled->name; led->ldev.name = led->name; - led->ldev.default_trigger = led->default_trigger; + led->ldev.default_trigger = pled->default_trigger; led->ldev.brightness = LED_OFF; led->ldev.brightness_set_blocking = pca9532_set_brightness;
[toc] | [next] | [standalone]
| From | Jacek Anaszewski <j.anaszewski@samsung.com> |
|---|---|
| Date | 2016-10-26 16:50 +0200 |
| Message-ID | <swxGF-51u-15@gated-at.bofh.it> |
| In reply to | #1509483 |
Hi Felix, Thanks for the patch. Applied. On 10/26/2016 04:08 PM, Felix Brack wrote: > The value for a led's default_trigger should come from platform data > instead of data (which is always 0). > > Signed-off-by: Felix Brack <fb@ltec.ch> > --- > > diff --git a/drivers/leds/leds-pca9532.c b/drivers/leds/leds-pca9532.c > index 09a7cffb..06e6310 100644 > --- a/drivers/leds/leds-pca9532.c > +++ b/drivers/leds/leds-pca9532.c > @@ -369,7 +369,7 @@ static int pca9532_configure(struct i2c_client *client, > led->state = pled->state; > led->name = pled->name; > led->ldev.name = led->name; > - led->ldev.default_trigger = led->default_trigger; > + led->ldev.default_trigger = pled->default_trigger; > led->ldev.brightness = LED_OFF; > led->ldev.brightness_set_blocking = > pca9532_set_brightness; > > > -- Best regards, Jacek Anaszewski
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web