Re: [PATCH] led: pca9532: Use default trigger value from platform data

From	Jacek Anaszewski <j.anaszewski@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] led: pca9532: Use default trigger value from platform data
Date	2016-10-26 16:50 +0200
Message-ID	<swxGF-51u-15@gated-at.bofh.it> (permalink)
References	<swxGF-51u-17@gated-at.bofh.it> <swxwZ-4Y6-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Felix,

Thanks for the patch. Applied.

On 10/26/2016 04:08 PM, Felix Brack wrote:
> The value for a led's default_trigger should come from platform data
> instead of data (which is always 0).
>
> Signed-off-by: Felix Brack <fb@ltec.ch>
> ---
>
> diff --git a/drivers/leds/leds-pca9532.c b/drivers/leds/leds-pca9532.c
> index 09a7cffb..06e6310 100644
> --- a/drivers/leds/leds-pca9532.c
> +++ b/drivers/leds/leds-pca9532.c
> @@ -369,7 +369,7 @@ static int pca9532_configure(struct i2c_client *client,
>  			led->state = pled->state;
>  			led->name = pled->name;
>  			led->ldev.name = led->name;
> -			led->ldev.default_trigger = led->default_trigger;
> +			led->ldev.default_trigger = pled->default_trigger;
>  			led->ldev.brightness = LED_OFF;
>  			led->ldev.brightness_set_blocking =
>  						pca9532_set_brightness;
>
>
>


-- 
Best regards,
Jacek Anaszewski

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] led: pca9532: Use default trigger value from platform data Felix Brack <fb@ltec.ch> - 2016-10-26 16:40 +0200
  Re: [PATCH] led: pca9532: Use default trigger value from platform data Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-10-26 16:50 +0200

csiph-web