Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1510206 > unrolled thread

RE: [PATCH 2/2] regmap: Avoid namespace collision within macro

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  RE: [PATCH 2/2] regmap: Avoid namespace collision within macro Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com> - 2016-10-27 16:10 +0200

#1510206 — RE: [PATCH 2/2] regmap: Avoid namespace collision within macro

> On Thu, Oct 27, 2016 at 10:33:19AM +0100, Ramesh Shanmugasundaram wrote:
> 
> >  #define regmap_read_poll_timeout(map, addr, val, cond, sleep_us,
> > timeout_us) \  ({ \
> > -	ktime_t timeout = ktime_add_us(ktime_get(), timeout_us); \
> > +	ktime_t __timeout = ktime_add_us(ktime_get(), timeout_us); \
> >  	int ret; \
> 
> Why is timeout an issue and not ret?

It is! However, it is less likely for someone to use "ret" as a variable name for the given parameter list. Hence, I fixed timeout alone. Feel free to fix "ret" as well. 

Thanks,
Ramesh

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web