RE: [PATCH 2/2] regmap: Avoid namespace collision within macro

From	Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH 2/2] regmap: Avoid namespace collision within macro
Date	2016-10-27 16:10 +0200
Message-ID	<swTxw-2VB-27@gated-at.bofh.it> (permalink)
References	<swTxw-2VB-29@gated-at.bofh.it> <swTxw-2VB-31@gated-at.bofh.it> <swTxw-2VB-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> On Thu, Oct 27, 2016 at 10:33:19AM +0100, Ramesh Shanmugasundaram wrote:
> 
> >  #define regmap_read_poll_timeout(map, addr, val, cond, sleep_us,
> > timeout_us) \  ({ \
> > -	ktime_t timeout = ktime_add_us(ktime_get(), timeout_us); \
> > +	ktime_t __timeout = ktime_add_us(ktime_get(), timeout_us); \
> >  	int ret; \
> 
> Why is timeout an issue and not ret?

It is! However, it is less likely for someone to use "ret" as a variable name for the given parameter list. Hence, I fixed timeout alone. Feel free to fix "ret" as well. 

Thanks,
Ramesh

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

RE: [PATCH 2/2] regmap: Avoid namespace collision within macro Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com> - 2016-10-27 16:10 +0200

csiph-web