Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1506764 > unrolled thread
| Started by | Nadim Almas <nadim.902@gmail.com> |
|---|---|
| First post | 2016-10-23 23:10 +0200 |
| Last post | 2016-10-24 13:20 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] Staging:board:board: fix implicit declaration of function Nadim Almas <nadim.902@gmail.com> - 2016-10-23 23:10 +0200
Re: [PATCH] Staging:board:board: fix implicit declaration of function Dan Carpenter <dan.carpenter@oracle.com> - 2016-10-24 12:50 +0200
Re: [PATCH] Staging:board:board: fix implicit declaration of function Geert Uytterhoeven <geert@linux-m68k.org> - 2016-10-24 13:20 +0200
| From | Nadim Almas <nadim.902@gmail.com> |
|---|---|
| Date | 2016-10-23 23:10 +0200 |
| Subject | [PATCH] Staging:board:board: fix implicit declaration of function |
| Message-ID | <svybL-65C-1@gated-at.bofh.it> |
implicit declaration of function ‘of_find_all_nodes’ reported by sparse Signed-off-by: Nadim Almas <nadim.902@gmail.com> --- drivers/staging/board/board.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/board/board.c b/drivers/staging/board/board.c index 86dc411..6978db5 100644 --- a/drivers/staging/board/board.c +++ b/drivers/staging/board/board.c @@ -22,6 +22,7 @@ #include "board.h" +struct device_node *of_find_all_nodes(struct device_node *); static struct device_node *irqc_node __initdata; static unsigned int irqc_base __initdata; -- 2.7.4
[toc] | [next] | [standalone]
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Date | 2016-10-24 12:50 +0200 |
| Message-ID | <svKZj-6tF-7@gated-at.bofh.it> |
| In reply to | #1506764 |
On Mon, Oct 24, 2016 at 02:35:26AM +0530, Nadim Almas wrote: > implicit declaration of function ‘of_find_all_nodes’ reported by sparse > No. Include the correct header file instead. regards, dan carpenter
[toc] | [prev] | [next] | [standalone]
| From | Geert Uytterhoeven <geert@linux-m68k.org> |
|---|---|
| Date | 2016-10-24 13:20 +0200 |
| Message-ID | <svLsl-6Te-9@gated-at.bofh.it> |
| In reply to | #1507087 |
On Mon, Oct 24, 2016 at 12:46 PM, Dan Carpenter
<dan.carpenter@oracle.com> wrote:
> On Mon, Oct 24, 2016 at 02:35:26AM +0530, Nadim Almas wrote:
>> implicit declaration of function ‘of_find_all_nodes’ reported by sparse
>>
>
> No. Include the correct header file instead.
drivers/staging/board/board.c already includes <linux/of.h>, which provides
the prototype, but only if CONFIG_OF=y.
However, STAGING_BOARD depends on OF_ADDRESS and OF_IRQ,
which both depend on OF. So how can this happen??
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web