Re: [PATCH] Staging:board:board: fix implicit declaration of function

From	Geert Uytterhoeven <geert@linux-m68k.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Staging:board:board: fix implicit declaration of function
Date	2016-10-24 13:20 +0200
Message-ID	<svLsl-6Te-9@gated-at.bofh.it> (permalink)
References	<svybL-65C-1@gated-at.bofh.it> <svKZj-6tF-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Oct 24, 2016 at 12:46 PM, Dan Carpenter
<dan.carpenter@oracle.com> wrote:
> On Mon, Oct 24, 2016 at 02:35:26AM +0530, Nadim Almas wrote:
>> implicit declaration of function ‘of_find_all_nodes’ reported by sparse
>>
>
> No.  Include the correct header file instead.

drivers/staging/board/board.c already includes <linux/of.h>, which provides
the prototype, but only if CONFIG_OF=y.

However, STAGING_BOARD depends on OF_ADDRESS and OF_IRQ,
which both depend on OF. So how can this happen??

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Staging:board:board: fix implicit declaration of function Nadim Almas <nadim.902@gmail.com> - 2016-10-23 23:10 +0200
  Re: [PATCH] Staging:board:board: fix implicit declaration of function Dan Carpenter <dan.carpenter@oracle.com> - 2016-10-24 12:50 +0200
    Re: [PATCH] Staging:board:board: fix implicit declaration of function Geert Uytterhoeven <geert@linux-m68k.org> - 2016-10-24 13:20 +0200

csiph-web