Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1501822 > unrolled thread
| Started by | Felipe Balbi <felipe.balbi@linux.intel.com> |
|---|---|
| First post | 2016-10-17 11:50 +0200 |
| Last post | 2016-10-22 03:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH V2]usb: dwc2: Clear GUSBCFG.UsbTrdTim before setting Felipe Balbi <felipe.balbi@linux.intel.com> - 2016-10-17 11:50 +0200
RE: [PATCH V2]usb: dwc2: Clear GUSBCFG.UsbTrdTim before setting Lipengcheng <lpc.li@hisilicon.com> - 2016-10-22 03:50 +0200
| From | Felipe Balbi <felipe.balbi@linux.intel.com> |
|---|---|
| Date | 2016-10-17 11:50 +0200 |
| Subject | Re: [PATCH V2]usb: dwc2: Clear GUSBCFG.UsbTrdTim before setting |
| Message-ID | <stcIp-1IH-1@gated-at.bofh.it> |
[Multipart message — attachments visible in raw view] — view raw
Hi, Pengcheng Li <lpc.li@hisilicon.com> writes: > The USBTRDTIM field needs to be cleared before setting a new value. > Otherwise it will result in an incorrect value if phyif == GUSBCFG_PHYIF8. > > Change-Id: Ib3e33cf4fd15ada41dc070ff7b93858daafbd10f > Signed-off-by: Pengcheng Li <lpc.li@hisilicon.com> > Acked-by: John Youn <johnyoun@synopsys.com> which commit are you fixing? Seems like you're missing a: Fixes: foobar .... line here. Also, you need to remove Gerritisms from commit log ;-) -- balbi
[toc] | [next] | [standalone]
| From | Lipengcheng <lpc.li@hisilicon.com> |
|---|---|
| Date | 2016-10-22 03:50 +0200 |
| Message-ID | <suTBE-5e7-3@gated-at.bofh.it> |
| In reply to | #1501822 |
> -----Original Message----- > From: Felipe Balbi [mailto:felipe.balbi@linux.intel.com] > Sent: Monday, October 17, 2016 5:37 PM > To: Lipengcheng; johnyoun@synopsys.com > Cc: gregkh@linuxfoundation.org; linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org; Xuejiancheng; Lidongpo; Caizhiyong; Lipengcheng > Subject: Re: [PATCH V2]usb: dwc2: Clear GUSBCFG.UsbTrdTim before setting > > > Hi, > > Pengcheng Li <lpc.li@hisilicon.com> writes: > > The USBTRDTIM field needs to be cleared before setting a new value. > > Otherwise it will result in an incorrect value if phyif == GUSBCFG_PHYIF8. > > > > Change-Id: Ib3e33cf4fd15ada41dc070ff7b93858daafbd10f > > Signed-off-by: Pengcheng Li <lpc.li@hisilicon.com> > > Acked-by: John Youn <johnyoun@synopsys.com> > > which commit are you fixing? Seems like you're missing a: > commit c45574ff02d1d1f35a6bf4b8ad051fc06c001fc7. > Fixes: foobar .... > > line here. Also, you need to remove Gerritisms from commit log ;-) > Ok, I will remove at the next patch. > -- > Balbi Best Regards Pengcheng Li
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web