Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1506369

RE: [PATCH V2]usb: dwc2: Clear GUSBCFG.UsbTrdTim before setting

Show all headers | View raw

> -----Original Message-----
> From: Felipe Balbi [mailto:felipe.balbi@linux.intel.com]
> Sent: Monday, October 17, 2016 5:37 PM
> To: Lipengcheng; johnyoun@synopsys.com
> Cc: gregkh@linuxfoundation.org; linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org; Xuejiancheng; Lidongpo; Caizhiyong; Lipengcheng
> Subject: Re: [PATCH V2]usb: dwc2: Clear GUSBCFG.UsbTrdTim before setting
> 
> 
> Hi,
> 
> Pengcheng Li <lpc.li@hisilicon.com> writes:
> > The USBTRDTIM field needs to be cleared before setting a new value.
> > Otherwise it will result in an incorrect value if phyif == GUSBCFG_PHYIF8.
> >
> > Change-Id: Ib3e33cf4fd15ada41dc070ff7b93858daafbd10f
> > Signed-off-by: Pengcheng Li <lpc.li@hisilicon.com>
> > Acked-by: John Youn <johnyoun@synopsys.com>
> 
> which commit are you fixing? Seems like you're missing a:
> 
commit c45574ff02d1d1f35a6bf4b8ad051fc06c001fc7.
> Fixes: foobar ....
> 
> line here. Also, you need to remove Gerritisms from commit log ;-)
> 
Ok, I will remove at the next patch.
> --
> Balbi

Best Regards
Pengcheng Li

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH V2]usb: dwc2: Clear GUSBCFG.UsbTrdTim before setting Felipe Balbi <felipe.balbi@linux.intel.com> - 2016-10-17 11:50 +0200
  RE: [PATCH V2]usb: dwc2: Clear GUSBCFG.UsbTrdTim before setting Lipengcheng <lpc.li@hisilicon.com> - 2016-10-22 03:50 +0200

csiph-web