Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1504299 > unrolled thread

[PATCH] hwrng: meson: Remove unneeded platform MODULE_ALIAS

Started byJavier Martinez Canillas <javier@osg.samsung.com>
First post2016-10-19 22:00 +0200
Last post2016-10-25 05:50 +0200
Articles 4 — 4 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] hwrng: meson: Remove unneeded platform MODULE_ALIAS Javier Martinez Canillas <javier@osg.samsung.com> - 2016-10-19 22:00 +0200
    Re: [PATCH] hwrng: meson: Remove unneeded platform MODULE_ALIAS Kevin Hilman <khilman@baylibre.com> - 2016-10-20 18:30 +0200
    Re: [PATCH] hwrng: meson: Remove unneeded platform MODULE_ALIAS Neil Armstrong <narmstrong@baylibre.com> - 2016-10-21 16:20 +0200
    Re: [PATCH] hwrng: meson: Remove unneeded platform MODULE_ALIAS Herbert Xu <herbert@gondor.apana.org.au> - 2016-10-25 05:50 +0200

#1504299 — [PATCH] hwrng: meson: Remove unneeded platform MODULE_ALIAS

FromJavier Martinez Canillas <javier@osg.samsung.com>
Date2016-10-19 22:00 +0200
Subject[PATCH] hwrng: meson: Remove unneeded platform MODULE_ALIAS
Message-ID<su5bP-5KC-1@gated-at.bofh.it>
The Amlogic Meson is a DT-only platform, which means the devices are
registered via OF and not using the legacy platform devices support.

So there's no need to have a MODULE_ALIAS("platform:meson-rng") since
the reported uevent MODALIAS to user-space will always be the OF one.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 drivers/char/hw_random/meson-rng.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/char/hw_random/meson-rng.c b/drivers/char/hw_random/meson-rng.c
index 51864a509be7..119d698439ae 100644
--- a/drivers/char/hw_random/meson-rng.c
+++ b/drivers/char/hw_random/meson-rng.c
@@ -122,7 +122,6 @@ static struct platform_driver meson_rng_driver = {
 
 module_platform_driver(meson_rng_driver);
 
-MODULE_ALIAS("platform:meson-rng");
 MODULE_DESCRIPTION("Meson H/W Random Number Generator driver");
 MODULE_AUTHOR("Lawrence Mok <lawrence.mok@amlogic.com>");
 MODULE_AUTHOR("Neil Armstrong <narmstrong@baylibre.com>");
-- 
2.7.4

[toc] | [next] | [standalone]

#1505076

FromKevin Hilman <khilman@baylibre.com>
Date2016-10-20 18:30 +0200
Message-ID<suoo9-1zb-9@gated-at.bofh.it>
In reply to#1504299
Javier Martinez Canillas <javier@osg.samsung.com> writes:

> The Amlogic Meson is a DT-only platform, which means the devices are
> registered via OF and not using the legacy platform devices support.
>
> So there's no need to have a MODULE_ALIAS("platform:meson-rng") since
> the reported uevent MODALIAS to user-space will always be the OF one.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

Acked-by: Kevin Hilman <khilman@baylibre.com>

> ---
>
>  drivers/char/hw_random/meson-rng.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/char/hw_random/meson-rng.c b/drivers/char/hw_random/meson-rng.c
> index 51864a509be7..119d698439ae 100644
> --- a/drivers/char/hw_random/meson-rng.c
> +++ b/drivers/char/hw_random/meson-rng.c
> @@ -122,7 +122,6 @@ static struct platform_driver meson_rng_driver = {
>  
>  module_platform_driver(meson_rng_driver);
>  
> -MODULE_ALIAS("platform:meson-rng");
>  MODULE_DESCRIPTION("Meson H/W Random Number Generator driver");
>  MODULE_AUTHOR("Lawrence Mok <lawrence.mok@amlogic.com>");
>  MODULE_AUTHOR("Neil Armstrong <narmstrong@baylibre.com>");

[toc] | [prev] | [next] | [standalone]

#1505983

FromNeil Armstrong <narmstrong@baylibre.com>
Date2016-10-21 16:20 +0200
Message-ID<suIPU-6HU-3@gated-at.bofh.it>
In reply to#1504299
On 10/19/2016 09:50 PM, Javier Martinez Canillas wrote:
> The Amlogic Meson is a DT-only platform, which means the devices are
> registered via OF and not using the legacy platform devices support.
> 
> So there's no need to have a MODULE_ALIAS("platform:meson-rng") since
> the reported uevent MODALIAS to user-space will always be the OF one.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
> 
>  drivers/char/hw_random/meson-rng.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/char/hw_random/meson-rng.c b/drivers/char/hw_random/meson-rng.c
> index 51864a509be7..119d698439ae 100644
> --- a/drivers/char/hw_random/meson-rng.c
> +++ b/drivers/char/hw_random/meson-rng.c
> @@ -122,7 +122,6 @@ static struct platform_driver meson_rng_driver = {
>  
>  module_platform_driver(meson_rng_driver);
>  
> -MODULE_ALIAS("platform:meson-rng");
>  MODULE_DESCRIPTION("Meson H/W Random Number Generator driver");
>  MODULE_AUTHOR("Lawrence Mok <lawrence.mok@amlogic.com>");
>  MODULE_AUTHOR("Neil Armstrong <narmstrong@baylibre.com>");
> 

Acked-by: Neil Armstrong <narmstrong@baylibre.com>

[toc] | [prev] | [next] | [standalone]

#1507953

FromHerbert Xu <herbert@gondor.apana.org.au>
Date2016-10-25 05:50 +0200
Message-ID<sw0Uq-6B-21@gated-at.bofh.it>
In reply to#1504299
On Wed, Oct 19, 2016 at 04:50:18PM -0300, Javier Martinez Canillas wrote:
> The Amlogic Meson is a DT-only platform, which means the devices are
> registered via OF and not using the legacy platform devices support.
> 
> So there's no need to have a MODULE_ALIAS("platform:meson-rng") since
> the reported uevent MODALIAS to user-space will always be the OF one.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web