Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1505983

Re: [PATCH] hwrng: meson: Remove unneeded platform MODULE_ALIAS

Show all headers | View raw

On 10/19/2016 09:50 PM, Javier Martinez Canillas wrote:
> The Amlogic Meson is a DT-only platform, which means the devices are
> registered via OF and not using the legacy platform devices support.
> 
> So there's no need to have a MODULE_ALIAS("platform:meson-rng") since
> the reported uevent MODALIAS to user-space will always be the OF one.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
> 
>  drivers/char/hw_random/meson-rng.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/char/hw_random/meson-rng.c b/drivers/char/hw_random/meson-rng.c
> index 51864a509be7..119d698439ae 100644
> --- a/drivers/char/hw_random/meson-rng.c
> +++ b/drivers/char/hw_random/meson-rng.c
> @@ -122,7 +122,6 @@ static struct platform_driver meson_rng_driver = {
>  
>  module_platform_driver(meson_rng_driver);
>  
> -MODULE_ALIAS("platform:meson-rng");
>  MODULE_DESCRIPTION("Meson H/W Random Number Generator driver");
>  MODULE_AUTHOR("Lawrence Mok <lawrence.mok@amlogic.com>");
>  MODULE_AUTHOR("Neil Armstrong <narmstrong@baylibre.com>");
> 

Acked-by: Neil Armstrong <narmstrong@baylibre.com>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] hwrng: meson: Remove unneeded platform MODULE_ALIAS Javier Martinez Canillas <javier@osg.samsung.com> - 2016-10-19 22:00 +0200
  Re: [PATCH] hwrng: meson: Remove unneeded platform MODULE_ALIAS Kevin Hilman <khilman@baylibre.com> - 2016-10-20 18:30 +0200
  Re: [PATCH] hwrng: meson: Remove unneeded platform MODULE_ALIAS Neil Armstrong <narmstrong@baylibre.com> - 2016-10-21 16:20 +0200
  Re: [PATCH] hwrng: meson: Remove unneeded platform MODULE_ALIAS Herbert Xu <herbert@gondor.apana.org.au> - 2016-10-25 05:50 +0200

csiph-web