Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1502119 > unrolled thread

[PATCH 0/5] [media] Fix module autoload for media platform drivers

Started byJavier Martinez Canillas <javier@osg.samsung.com>
First post2016-10-17 17:50 +0200
Last post2016-10-17 18:10 +0200
Articles 7 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/5] [media] Fix module autoload for media platform drivers Javier Martinez Canillas <javier@osg.samsung.com> - 2016-10-17 17:50 +0200
    [PATCH 5/5] [media] st-cec: Fix module autoload Javier Martinez Canillas <javier@osg.samsung.com> - 2016-10-17 17:50 +0200
      Re: [PATCH 5/5] [media] st-cec: Fix module autoload Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2016-10-18 10:00 +0200
    [PATCH 1/5] [media] v4l: vsp1: Fix module autoload for OF registration Javier Martinez Canillas <javier@osg.samsung.com> - 2016-10-17 17:50 +0200
      Re: [PATCH 1/5] [media] v4l: vsp1: Fix module autoload for OF registration Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-10-17 18:10 +0200
    [PATCH 2/5] [media] v4l: rcar-fcp: Fix module autoload for OF registration Javier Martinez Canillas <javier@osg.samsung.com> - 2016-10-17 17:50 +0200
      Re: [PATCH 2/5] [media] v4l: rcar-fcp: Fix module autoload for OF registration Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-10-17 18:10 +0200

#1502119 — [PATCH 0/5] [media] Fix module autoload for media platform drivers

FromJavier Martinez Canillas <javier@osg.samsung.com>
Date2016-10-17 17:50 +0200
Subject[PATCH 0/5] [media] Fix module autoload for media platform drivers
Message-ID<stikO-5jI-19@gated-at.bofh.it>
Hello Mauro,

I noticed that module autoload won't be working in a bunch of media
platform drivers because the module alias information is not filled
in the modules. This patch series contains the fixes for them.

Best regards,
Javier


Javier Martinez Canillas (5):
  [media] v4l: vsp1: Fix module autoload for OF registration
  [media] v4l: rcar-fcp: Fix module autoload for OF registration
  [media] rc: meson-ir: Fix module autoload
  [media] s5p-cec: Fix module autoload
  [media] st-cec: Fix module autoload

 drivers/media/platform/rcar-fcp.c       | 1 +
 drivers/media/platform/vsp1/vsp1_drv.c  | 1 +
 drivers/media/rc/meson-ir.c             | 1 +
 drivers/staging/media/s5p-cec/s5p_cec.c | 1 +
 drivers/staging/media/st-cec/stih-cec.c | 1 +
 5 files changed, 5 insertions(+)

-- 
2.7.4

[toc] | [next] | [standalone]

#1502122 — [PATCH 5/5] [media] st-cec: Fix module autoload

FromJavier Martinez Canillas <javier@osg.samsung.com>
Date2016-10-17 17:50 +0200
Subject[PATCH 5/5] [media] st-cec: Fix module autoload
Message-ID<stikP-5jI-45@gated-at.bofh.it>
In reply to#1502119
If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.

Export the module alias information using the MODULE_DEVICE_TABLE() macro.

Before this patch:

$ modinfo drivers/staging/media//st-cec/stih-cec.ko | grep alias
$

After this patch:

$ modinfo drivers/staging/media//st-cec/stih-cec.ko | grep alias
alias:          of:N*T*Cst,stih-cecC*
alias:          of:N*T*Cst,stih-cec

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

---

 drivers/staging/media/st-cec/stih-cec.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/media/st-cec/stih-cec.c b/drivers/staging/media/st-cec/stih-cec.c
index 214344866a6b..19d3ff30c8f8 100644
--- a/drivers/staging/media/st-cec/stih-cec.c
+++ b/drivers/staging/media/st-cec/stih-cec.c
@@ -363,6 +363,7 @@ static const struct of_device_id stih_cec_match[] = {
 	},
 	{},
 };
+MODULE_DEVICE_TABLE(of, stih_cec_match);
 
 static struct platform_driver stih_cec_pdrv = {
 	.probe	= stih_cec_probe,
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1502774 — Re: [PATCH 5/5] [media] st-cec: Fix module autoload

FromBenjamin Gaignard <benjamin.gaignard@linaro.org>
Date2016-10-18 10:00 +0200
SubjectRe: [PATCH 5/5] [media] st-cec: Fix module autoload
Message-ID<stxtw-7at-13@gated-at.bofh.it>
In reply to#1502122
Thanks,

Acked-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>

2016-10-17 17:44 GMT+02:00 Javier Martinez Canillas <javier@osg.samsung.com>:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
>
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>
> Before this patch:
>
> $ modinfo drivers/staging/media//st-cec/stih-cec.ko | grep alias
> $
>
> After this patch:
>
> $ modinfo drivers/staging/media//st-cec/stih-cec.ko | grep alias
> alias:          of:N*T*Cst,stih-cecC*
> alias:          of:N*T*Cst,stih-cec
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
>  drivers/staging/media/st-cec/stih-cec.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/media/st-cec/stih-cec.c b/drivers/staging/media/st-cec/stih-cec.c
> index 214344866a6b..19d3ff30c8f8 100644
> --- a/drivers/staging/media/st-cec/stih-cec.c
> +++ b/drivers/staging/media/st-cec/stih-cec.c
> @@ -363,6 +363,7 @@ static const struct of_device_id stih_cec_match[] = {
>         },
>         {},
>  };
> +MODULE_DEVICE_TABLE(of, stih_cec_match);
>
>  static struct platform_driver stih_cec_pdrv = {
>         .probe  = stih_cec_probe,
> --
> 2.7.4
>



-- 
Benjamin Gaignard

Graphic Study Group

Linaro.org │ Open source software for ARM SoCs

Follow Linaro: Facebook | Twitter | Blog

[toc] | [prev] | [next] | [standalone]

#1502124 — [PATCH 1/5] [media] v4l: vsp1: Fix module autoload for OF registration

FromJavier Martinez Canillas <javier@osg.samsung.com>
Date2016-10-17 17:50 +0200
Subject[PATCH 1/5] [media] v4l: vsp1: Fix module autoload for OF registration
Message-ID<stikO-5jI-35@gated-at.bofh.it>
In reply to#1502119
If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.

Export the module alias information using the MODULE_DEVICE_TABLE() macro.

Before this patch:

$ modinfo drivers/media/platform/vsp1/vsp1.ko | grep alias
alias:          vsp1

After this patch:

$ modinfo drivers/media/platform/vsp1/vsp1.ko | grep alias
alias:          vsp1
alias:          of:N*T*Crenesas,vsp2C*
alias:          of:N*T*Crenesas,vsp2
alias:          of:N*T*Crenesas,vsp1C*
alias:          of:N*T*Crenesas,vsp1

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 drivers/media/platform/vsp1/vsp1_drv.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/media/platform/vsp1/vsp1_drv.c b/drivers/media/platform/vsp1/vsp1_drv.c
index 57c713a4e1df..aa237b48ad55 100644
--- a/drivers/media/platform/vsp1/vsp1_drv.c
+++ b/drivers/media/platform/vsp1/vsp1_drv.c
@@ -770,6 +770,7 @@ static const struct of_device_id vsp1_of_match[] = {
 	{ .compatible = "renesas,vsp2" },
 	{ },
 };
+MODULE_DEVICE_TABLE(of, vsp1_of_match);
 
 static struct platform_driver vsp1_platform_driver = {
 	.probe		= vsp1_probe,
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1502155 — Re: [PATCH 1/5] [media] v4l: vsp1: Fix module autoload for OF registration

FromLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Date2016-10-17 18:10 +0200
SubjectRe: [PATCH 1/5] [media] v4l: vsp1: Fix module autoload for OF registration
Message-ID<stiEa-5Hd-11@gated-at.bofh.it>
In reply to#1502124
Hi Javier,

Thank you for the patch.

On Monday 17 Oct 2016 12:44:08 Javier Martinez Canillas wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
> 
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
> 
> Before this patch:
> 
> $ modinfo drivers/media/platform/vsp1/vsp1.ko | grep alias
> alias:          vsp1
> 
> After this patch:
> 
> $ modinfo drivers/media/platform/vsp1/vsp1.ko | grep alias
> alias:          vsp1
> alias:          of:N*T*Crenesas,vsp2C*
> alias:          of:N*T*Crenesas,vsp2
> alias:          of:N*T*Crenesas,vsp1C*
> alias:          of:N*T*Crenesas,vsp1
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> 
>  drivers/media/platform/vsp1/vsp1_drv.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/platform/vsp1/vsp1_drv.c
> b/drivers/media/platform/vsp1/vsp1_drv.c index 57c713a4e1df..aa237b48ad55
> 100644
> --- a/drivers/media/platform/vsp1/vsp1_drv.c
> +++ b/drivers/media/platform/vsp1/vsp1_drv.c
> @@ -770,6 +770,7 @@ static const struct of_device_id vsp1_of_match[] = {
>  	{ .compatible = "renesas,vsp2" },
>  	{ },
>  };
> +MODULE_DEVICE_TABLE(of, vsp1_of_match);
> 
>  static struct platform_driver vsp1_platform_driver = {
>  	.probe		= vsp1_probe,

-- 
Regards,

Laurent Pinchart

[toc] | [prev] | [next] | [standalone]

#1502125 — [PATCH 2/5] [media] v4l: rcar-fcp: Fix module autoload for OF registration

FromJavier Martinez Canillas <javier@osg.samsung.com>
Date2016-10-17 17:50 +0200
Subject[PATCH 2/5] [media] v4l: rcar-fcp: Fix module autoload for OF registration
Message-ID<stikP-5jI-47@gated-at.bofh.it>
In reply to#1502119
If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.

Export the module alias information using the MODULE_DEVICE_TABLE() macro.

Before this patch:

$ modinfo drivers/media/platform/rcar-fcp.ko | grep alias
alias:          rcar-fcp

After this patch:

$ modinfo drivers/media/platform/rcar-fcp.ko | grep alias
alias:          rcar-fcp
alias:          of:N*T*Crenesas,fcpvC*
alias:          of:N*T*Crenesas,fcpv
alias:          of:N*T*Crenesas,fcpfC*
alias:          of:N*T*Crenesas,fcpf

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 drivers/media/platform/rcar-fcp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/media/platform/rcar-fcp.c b/drivers/media/platform/rcar-fcp.c
index f3a3f31cdfa9..7146fc5ef168 100644
--- a/drivers/media/platform/rcar-fcp.c
+++ b/drivers/media/platform/rcar-fcp.c
@@ -169,6 +169,7 @@ static const struct of_device_id rcar_fcp_of_match[] = {
 	{ .compatible = "renesas,fcpv" },
 	{ },
 };
+MODULE_DEVICE_TABLE(of, rcar_fcp_of_match);
 
 static struct platform_driver rcar_fcp_platform_driver = {
 	.probe		= rcar_fcp_probe,
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1502152 — Re: [PATCH 2/5] [media] v4l: rcar-fcp: Fix module autoload for OF registration

FromLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Date2016-10-17 18:10 +0200
SubjectRe: [PATCH 2/5] [media] v4l: rcar-fcp: Fix module autoload for OF registration
Message-ID<stiE9-5Hd-5@gated-at.bofh.it>
In reply to#1502125
Hi Javier,

Thank you for the patch.

On Monday 17 Oct 2016 12:44:09 Javier Martinez Canillas wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
> 
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
> 
> Before this patch:
> 
> $ modinfo drivers/media/platform/rcar-fcp.ko | grep alias
> alias:          rcar-fcp
> 
> After this patch:
> 
> $ modinfo drivers/media/platform/rcar-fcp.ko | grep alias
> alias:          rcar-fcp
> alias:          of:N*T*Crenesas,fcpvC*
> alias:          of:N*T*Crenesas,fcpv
> alias:          of:N*T*Crenesas,fcpfC*
> alias:          of:N*T*Crenesas,fcpf
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> 
>  drivers/media/platform/rcar-fcp.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/platform/rcar-fcp.c
> b/drivers/media/platform/rcar-fcp.c index f3a3f31cdfa9..7146fc5ef168 100644
> --- a/drivers/media/platform/rcar-fcp.c
> +++ b/drivers/media/platform/rcar-fcp.c
> @@ -169,6 +169,7 @@ static const struct of_device_id rcar_fcp_of_match[] = {
> { .compatible = "renesas,fcpv" },
>  	{ },
>  };
> +MODULE_DEVICE_TABLE(of, rcar_fcp_of_match);
> 
>  static struct platform_driver rcar_fcp_platform_driver = {
>  	.probe		= rcar_fcp_probe,

-- 
Regards,

Laurent Pinchart

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web