Re: [PATCH 5/5] [media] st-cec: Fix module autoload

From	Benjamin Gaignard <benjamin.gaignard@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 5/5] [media] st-cec: Fix module autoload
Date	2016-10-18 10:00 +0200
Message-ID	<stxtw-7at-13@gated-at.bofh.it> (permalink)
References	<stikO-5jI-19@gated-at.bofh.it> <stikP-5jI-45@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Thanks,

Acked-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>

2016-10-17 17:44 GMT+02:00 Javier Martinez Canillas <javier@osg.samsung.com>:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
>
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>
> Before this patch:
>
> $ modinfo drivers/staging/media//st-cec/stih-cec.ko | grep alias
> $
>
> After this patch:
>
> $ modinfo drivers/staging/media//st-cec/stih-cec.ko | grep alias
> alias:          of:N*T*Cst,stih-cecC*
> alias:          of:N*T*Cst,stih-cec
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
>  drivers/staging/media/st-cec/stih-cec.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/media/st-cec/stih-cec.c b/drivers/staging/media/st-cec/stih-cec.c
> index 214344866a6b..19d3ff30c8f8 100644
> --- a/drivers/staging/media/st-cec/stih-cec.c
> +++ b/drivers/staging/media/st-cec/stih-cec.c
> @@ -363,6 +363,7 @@ static const struct of_device_id stih_cec_match[] = {
>         },
>         {},
>  };
> +MODULE_DEVICE_TABLE(of, stih_cec_match);
>
>  static struct platform_driver stih_cec_pdrv = {
>         .probe  = stih_cec_probe,
> --
> 2.7.4
>



-- 
Benjamin Gaignard

Graphic Study Group

Linaro.org │ Open source software for ARM SoCs

Follow Linaro: Facebook | Twitter | Blog

Thread

[PATCH 0/5] [media] Fix module autoload for media platform drivers Javier Martinez Canillas <javier@osg.samsung.com> - 2016-10-17 17:50 +0200
  [PATCH 5/5] [media] st-cec: Fix module autoload Javier Martinez Canillas <javier@osg.samsung.com> - 2016-10-17 17:50 +0200
    Re: [PATCH 5/5] [media] st-cec: Fix module autoload Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2016-10-18 10:00 +0200
  [PATCH 1/5] [media] v4l: vsp1: Fix module autoload for OF registration Javier Martinez Canillas <javier@osg.samsung.com> - 2016-10-17 17:50 +0200
    Re: [PATCH 1/5] [media] v4l: vsp1: Fix module autoload for OF registration Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-10-17 18:10 +0200
  [PATCH 2/5] [media] v4l: rcar-fcp: Fix module autoload for OF registration Javier Martinez Canillas <javier@osg.samsung.com> - 2016-10-17 17:50 +0200
    Re: [PATCH 2/5] [media] v4l: rcar-fcp: Fix module autoload for OF registration Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-10-17 18:10 +0200

csiph-web