Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1502142 > unrolled thread
| Started by | Jerome Forissier <jerome.forissier@linaro.org> |
|---|---|
| First post | 2016-10-17 18:00 +0200 |
| Last post | 2016-10-17 19:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] checkpatch: don't try to get maintained status when --no-tree is given Jerome Forissier <jerome.forissier@linaro.org> - 2016-10-17 18:00 +0200
Re: [PATCH] checkpatch: don't try to get maintained status when --no-tree is given Joe Perches <joe@perches.com> - 2016-10-17 19:10 +0200
| From | Jerome Forissier <jerome.forissier@linaro.org> |
|---|---|
| Date | 2016-10-17 18:00 +0200 |
| Subject | [PATCH] checkpatch: don't try to get maintained status when --no-tree is given |
| Message-ID | <stiuu-5no-41@gated-at.bofh.it> |
Fixes the following warning:
Use of uninitialized value $root in concatenation (.) or string at /path/to/checkpatch.pl line 764.
Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index a8368d1..aa694bc 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -761,7 +761,7 @@ sub seed_camelcase_file {
sub is_maintained_obsolete {
my ($filename) = @_;
- return 0 if (!(-e "$root/scripts/get_maintainer.pl"));
+ return 0 if (!$tree || !(-e "$root/scripts/get_maintainer.pl"));
my $status = `perl $root/scripts/get_maintainer.pl --status --nom --nol --nogit --nogit-fallback -f $filename 2>&1`;
--
2.7.4
[toc] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2016-10-17 19:10 +0200 |
| Subject | Re: [PATCH] checkpatch: don't try to get maintained status when --no-tree is given |
| Message-ID | <stjAe-6l5-33@gated-at.bofh.it> |
| In reply to | #1502142 |
On Mon, 2016-10-17 at 17:55 +0200, Jerome Forissier wrote:
> Fixes the following warning:
> Use of uninitialized value $root in concatenation (.) or string at /path/to/checkpatch.pl line 764.
Thanks Jerome.
> Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Acked-by: Joe Perches <joe@perches.com>
> ---
> scripts/checkpatch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index a8368d1..aa694bc 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -761,7 +761,7 @@ sub seed_camelcase_file {
> sub is_maintained_obsolete {
> my ($filename) = @_;
>
> - return 0 if (!(-e "$root/scripts/get_maintainer.pl"));
> + return 0 if (!$tree || !(-e "$root/scripts/get_maintainer.pl"));
>
> my $status = `perl $root/scripts/get_maintainer.pl --status --nom --nol --nogit --nogit-fallback -f $filename 2>&1`;
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web