Re: [PATCH] checkpatch: don't try to get maintained status when --no-tree is given

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] checkpatch: don't try to get maintained status when --no-tree is given
Date	2016-10-17 19:10 +0200
Message-ID	<stjAe-6l5-33@gated-at.bofh.it> (permalink)
References	<stiuu-5no-41@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 2016-10-17 at 17:55 +0200, Jerome Forissier wrote:
> Fixes the following warning:
> Use of uninitialized value $root in concatenation (.) or string at /path/to/checkpatch.pl line 764.

Thanks Jerome.

> Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>

Acked-by: Joe Perches <joe@perches.com>

> ---
>  scripts/checkpatch.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index a8368d1..aa694bc 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -761,7 +761,7 @@ sub seed_camelcase_file {
>  sub is_maintained_obsolete {
>  	my ($filename) = @_;
>  
> -	return 0 if (!(-e "$root/scripts/get_maintainer.pl"));
> +	return 0 if (!$tree || !(-e "$root/scripts/get_maintainer.pl"));
>  
>  	my $status = `perl $root/scripts/get_maintainer.pl --status --nom --nol --nogit --nogit-fallback -f $filename 2>&1`;

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] checkpatch: don't try to get maintained status when --no-tree is given Jerome Forissier <jerome.forissier@linaro.org> - 2016-10-17 18:00 +0200
  Re: [PATCH] checkpatch: don't try to get maintained status when  --no-tree is given Joe Perches <joe@perches.com> - 2016-10-17 19:10 +0200

csiph-web