Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1501985 > unrolled thread
| Started by | "H. Nikolaus Schaller" <hns@goldelico.com> |
|---|---|
| First post | 2016-10-17 16:10 +0200 |
| Last post | 2016-10-17 19:00 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v4 7/8] drivers:input:ads7846(+tsc2046): fix spi module table "H. Nikolaus Schaller" <hns@goldelico.com> - 2016-10-17 16:10 +0200
Re: [PATCH v4 7/8] drivers:input:ads7846(+tsc2046): fix spi module table "Andrew F. Davis" <afd@ti.com> - 2016-10-17 18:00 +0200
Re: [PATCH v4 7/8] drivers:input:ads7846(+tsc2046): fix spi module table "H. Nikolaus Schaller" <hns@goldelico.com> - 2016-10-17 19:00 +0200
| From | "H. Nikolaus Schaller" <hns@goldelico.com> |
|---|---|
| Date | 2016-10-17 16:10 +0200 |
| Subject | [PATCH v4 7/8] drivers:input:ads7846(+tsc2046): fix spi module table |
| Message-ID | <stgM2-4uk-7@gated-at.bofh.it> |
Fix module table so that the driver is loaded if compiled
as module and requested by DT.
Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
---
drivers/input/touchscreen/ads7846.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c
index 400e421..9a5d84d 100644
--- a/drivers/input/touchscreen/ads7846.c
+++ b/drivers/input/touchscreen/ads7846.c
@@ -1532,6 +1532,17 @@ static int ads7846_remove(struct spi_device *spi)
return 0;
}
+static const struct spi_device_id ads7846_idtable[] = {
+ { "tsc2046", 0 },
+ { "ads7843", 0 },
+ { "ads7845", 0 },
+ { "ads7846", 0 },
+ { "ads7873", 0 },
+ { }
+};
+
+MODULE_DEVICE_TABLE(spi, ads7846_idtable);
+
static struct spi_driver ads7846_driver = {
.driver = {
.name = "ads7846",
--
2.7.3
[toc] | [next] | [standalone]
| From | "Andrew F. Davis" <afd@ti.com> |
|---|---|
| Date | 2016-10-17 18:00 +0200 |
| Subject | Re: [PATCH v4 7/8] drivers:input:ads7846(+tsc2046): fix spi module table |
| Message-ID | <stiuu-5no-35@gated-at.bofh.it> |
| In reply to | #1501985 |
On 10/17/2016 08:57 AM, H. Nikolaus Schaller wrote:
> Fix module table so that the driver is loaded if compiled
> as module and requested by DT.
>
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> ---
> drivers/input/touchscreen/ads7846.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c
> index 400e421..9a5d84d 100644
> --- a/drivers/input/touchscreen/ads7846.c
> +++ b/drivers/input/touchscreen/ads7846.c
> @@ -1532,6 +1532,17 @@ static int ads7846_remove(struct spi_device *spi)
> return 0;
> }
>
> +static const struct spi_device_id ads7846_idtable[] = {
> + { "tsc2046", 0 },
> + { "ads7843", 0 },
> + { "ads7845", 0 },
> + { "ads7846", 0 },
> + { "ads7873", 0 },
> + { }
> +};
> +
no space needed
> +MODULE_DEVICE_TABLE(spi, ads7846_idtable);
> +
> static struct spi_driver ads7846_driver = {
> .driver = {
> .name = "ads7846",
>
the MODULE_ALIAS below can now also be removed with this patch.
[toc] | [prev] | [next] | [standalone]
| From | "H. Nikolaus Schaller" <hns@goldelico.com> |
|---|---|
| Date | 2016-10-17 19:00 +0200 |
| Message-ID | <stjqy-61C-61@gated-at.bofh.it> |
| In reply to | #1502143 |
> Am 17.10.2016 um 17:54 schrieb Andrew F. Davis <afd@ti.com>:
>
> On 10/17/2016 08:57 AM, H. Nikolaus Schaller wrote:
>> Fix module table so that the driver is loaded if compiled
>> as module and requested by DT.
>>
>> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
>> ---
>> drivers/input/touchscreen/ads7846.c | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c
>> index 400e421..9a5d84d 100644
>> --- a/drivers/input/touchscreen/ads7846.c
>> +++ b/drivers/input/touchscreen/ads7846.c
>> @@ -1532,6 +1532,17 @@ static int ads7846_remove(struct spi_device *spi)
>> return 0;
>> }
>>
>> +static const struct spi_device_id ads7846_idtable[] = {
>> + { "tsc2046", 0 },
>> + { "ads7843", 0 },
>> + { "ads7845", 0 },
>> + { "ads7846", 0 },
>> + { "ads7873", 0 },
>> + { }
>> +};
>> +
>
> no space needed
>
>> +MODULE_DEVICE_TABLE(spi, ads7846_idtable);
>> +
>> static struct spi_driver ads7846_driver = {
>> .driver = {
>> .name = "ads7846",
>>
>
> the MODULE_ALIAS below can now also be removed with this patch.
Ok! Noted for V5.
BR and thanks,
Nikolaus
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web