Re: [PATCH v4 7/8] drivers:input:ads7846(+tsc2046): fix spi module table

From	"H. Nikolaus Schaller" <hns@goldelico.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 7/8] drivers:input:ads7846(+tsc2046): fix spi module table
Date	2016-10-17 19:00 +0200
Message-ID	<stjqy-61C-61@gated-at.bofh.it> (permalink)
References	<stgM1-4uk-3@gated-at.bofh.it> <stgM2-4uk-7@gated-at.bofh.it> <stiuu-5no-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> Am 17.10.2016 um 17:54 schrieb Andrew F. Davis <afd@ti.com>:
> 
> On 10/17/2016 08:57 AM, H. Nikolaus Schaller wrote:
>> Fix module table so that the driver is loaded if compiled
>> as module and requested by DT.
>> 
>> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
>> ---
>> drivers/input/touchscreen/ads7846.c | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>> 
>> diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c
>> index 400e421..9a5d84d 100644
>> --- a/drivers/input/touchscreen/ads7846.c
>> +++ b/drivers/input/touchscreen/ads7846.c
>> @@ -1532,6 +1532,17 @@ static int ads7846_remove(struct spi_device *spi)
>> 	return 0;
>> }
>> 
>> +static const struct spi_device_id ads7846_idtable[] = {
>> +	{ "tsc2046", 0 },
>> +	{ "ads7843", 0 },
>> +	{ "ads7845", 0 },
>> +	{ "ads7846", 0 },
>> +	{ "ads7873", 0 },
>> +	{ }
>> +};
>> +
> 
> no space needed
> 
>> +MODULE_DEVICE_TABLE(spi, ads7846_idtable);
>> +
>> static struct spi_driver ads7846_driver = {
>> 	.driver = {
>> 		.name	= "ads7846",
>> 
> 
> the MODULE_ALIAS below can now also be removed with this patch.

Ok! Noted for V5.

BR and thanks,
Nikolaus

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v4 7/8] drivers:input:ads7846(+tsc2046): fix spi module table "H. Nikolaus Schaller" <hns@goldelico.com> - 2016-10-17 16:10 +0200
  Re: [PATCH v4 7/8] drivers:input:ads7846(+tsc2046): fix spi module  table "Andrew F. Davis" <afd@ti.com> - 2016-10-17 18:00 +0200
    Re: [PATCH v4 7/8] drivers:input:ads7846(+tsc2046): fix spi module table "H. Nikolaus Schaller" <hns@goldelico.com> - 2016-10-17 19:00 +0200

csiph-web