Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1501882 > unrolled thread
| Started by | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| First post | 2016-10-17 13:20 +0200 |
| Last post | 2016-10-17 15:10 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] usb: ehci-platform: increase EHCI_MAX_RSTS to 4 Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-10-17 13:20 +0200
Re: [PATCH] usb: ehci-platform: increase EHCI_MAX_RSTS to 4 Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-10-17 14:40 +0200
Re: [PATCH] usb: ehci-platform: increase EHCI_MAX_RSTS to 4 Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-10-17 15:10 +0200
| From | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| Date | 2016-10-17 13:20 +0200 |
| Subject | [PATCH] usb: ehci-platform: increase EHCI_MAX_RSTS to 4 |
| Message-ID | <ste7v-2Kh-1@gated-at.bofh.it> |
Socionext LD11 SoC (arch/arm64/boot/dts/socionext/uniphier-ld11.dtsi)
needs to handle 4 reset lines for EHCI.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
drivers/usb/host/ehci-platform.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ehci-platform.c b/drivers/usb/host/ehci-platform.c
index 876dca4..a268d9e 100644
--- a/drivers/usb/host/ehci-platform.c
+++ b/drivers/usb/host/ehci-platform.c
@@ -39,7 +39,7 @@
#define DRIVER_DESC "EHCI generic platform driver"
#define EHCI_MAX_CLKS 4
-#define EHCI_MAX_RSTS 3
+#define EHCI_MAX_RSTS 4
#define hcd_to_ehci_priv(h) ((struct ehci_platform_priv *)hcd_to_ehci(h)->priv)
struct ehci_platform_priv {
--
1.9.1
[toc] | [next] | [standalone]
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2016-10-17 14:40 +0200 |
| Message-ID | <stfmW-3uj-23@gated-at.bofh.it> |
| In reply to | #1501882 |
On Mon, Oct 17, 2016 at 08:11:59PM +0900, Masahiro Yamada wrote: > Socionext LD11 SoC (arch/arm64/boot/dts/socionext/uniphier-ld11.dtsi) > needs to handle 4 reset lines for EHCI. Why? What makes it different from other EHCI implementations? thanks, greg k-h
[toc] | [prev] | [next] | [standalone]
| From | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| Date | 2016-10-17 15:10 +0200 |
| Message-ID | <stfPX-3TZ-15@gated-at.bofh.it> |
| In reply to | #1501940 |
Hi Greg,
2016-10-17 21:30 GMT+09:00 Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
> On Mon, Oct 17, 2016 at 08:11:59PM +0900, Masahiro Yamada wrote:
>> Socionext LD11 SoC (arch/arm64/boot/dts/socionext/uniphier-ld11.dtsi)
>> needs to handle 4 reset lines for EHCI.
>
> Why? What makes it different from other EHCI implementations?
>
> thanks,
>
> greg k-h
This is a generic EHCI driver, but the number of clocks/resets
are SoC-specific.
The following patch you picked up will remind you something?
commit 73577d61799e8d8bb7d69a9acdc54923e5998138
Author: Icenowy Zheng <icenowy@aosc.xyz>
Date: Fri Aug 12 11:06:22 2016 +0800
ehci-platform: add the max clock number to 4
Allwinner A64 EHCI requires 4 clocks to be enabled.
Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
--
Best Regards
Masahiro Yamada
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web