Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1501889 > unrolled thread

[PATCH] crygpu/drm/exynos/exynos_hdmi - Unmap region obtained by of_iomap

Started byArvind Yadav <arvind.yadav.cs@gmail.com>
First post2016-10-17 13:20 +0200
Last post2016-10-17 13:40 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] crygpu/drm/exynos/exynos_hdmi - Unmap region obtained by of_iomap Arvind Yadav <arvind.yadav.cs@gmail.com> - 2016-10-17 13:20 +0200
    Re: [PATCH] crygpu/drm/exynos/exynos_hdmi - Unmap region obtained by  of_iomap Andrzej Hajda <a.hajda@samsung.com> - 2016-10-17 13:40 +0200

#1501889 — [PATCH] crygpu/drm/exynos/exynos_hdmi - Unmap region obtained by of_iomap

FromArvind Yadav <arvind.yadav.cs@gmail.com>
Date2016-10-17 13:20 +0200
Subject[PATCH] crygpu/drm/exynos/exynos_hdmi - Unmap region obtained by of_iomap
Message-ID<ste7v-2Kh-27@gated-at.bofh.it>
Free memory mapping, if hdmi_probe is not successful.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/gpu/drm/exynos/exynos_hdmi.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c
index 2275efe..9b7857b 100644
--- a/drivers/gpu/drm/exynos/exynos_hdmi.c
+++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
@@ -1901,6 +1901,8 @@ err_disable_pm_runtime:
 err_hdmiphy:
 	if (hdata->hdmiphy_port)
 		put_device(&hdata->hdmiphy_port->dev);
+	if (hdata->regs_hdmiphy)
+		iounmap(hdata->regs_hdmiphy);
 err_ddc:
 	put_device(&hdata->ddc_adpt->dev);
 
-- 
1.7.9.5

[toc] | [next] | [standalone]


#1501896 — Re: [PATCH] crygpu/drm/exynos/exynos_hdmi - Unmap region obtained by of_iomap

FromAndrzej Hajda <a.hajda@samsung.com>
Date2016-10-17 13:40 +0200
SubjectRe: [PATCH] crygpu/drm/exynos/exynos_hdmi - Unmap region obtained by of_iomap
Message-ID<steqR-2QN-1@gated-at.bofh.it>
In reply to#1501889
Hi,

On 17.10.2016 13:09, Arvind Yadav wrote:
> Free memory mapping, if hdmi_probe is not successful.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Subject prefix is incorrect.

> ---
>  drivers/gpu/drm/exynos/exynos_hdmi.c |    2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c
> index 2275efe..9b7857b 100644
> --- a/drivers/gpu/drm/exynos/exynos_hdmi.c
> +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
> @@ -1901,6 +1901,8 @@ err_disable_pm_runtime:
>  err_hdmiphy:
>  	if (hdata->hdmiphy_port)
>  		put_device(&hdata->hdmiphy_port->dev);
> +	if (hdata->regs_hdmiphy)
> +		iounmap(hdata->regs_hdmiphy);

Thats OK, you can add also unmap to hdmi_remove.

Regards
Andrzej

>  err_ddc:
>  	put_device(&hdata->ddc_adpt->dev);
>  

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web