Re: [PATCH] crygpu/drm/exynos/exynos_hdmi - Unmap region obtained by of_iomap

From	Andrzej Hajda <a.hajda@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] crygpu/drm/exynos/exynos_hdmi - Unmap region obtained by of_iomap
Date	2016-10-17 13:40 +0200
Message-ID	<steqR-2QN-1@gated-at.bofh.it> (permalink)
References	<steqR-2QN-3@gated-at.bofh.it> <ste7v-2Kh-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

On 17.10.2016 13:09, Arvind Yadav wrote:
> Free memory mapping, if hdmi_probe is not successful.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Subject prefix is incorrect.

> ---
>  drivers/gpu/drm/exynos/exynos_hdmi.c |    2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c
> index 2275efe..9b7857b 100644
> --- a/drivers/gpu/drm/exynos/exynos_hdmi.c
> +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
> @@ -1901,6 +1901,8 @@ err_disable_pm_runtime:
>  err_hdmiphy:
>  	if (hdata->hdmiphy_port)
>  		put_device(&hdata->hdmiphy_port->dev);
> +	if (hdata->regs_hdmiphy)
> +		iounmap(hdata->regs_hdmiphy);

Thats OK, you can add also unmap to hdmi_remove.

Regards
Andrzej

>  err_ddc:
>  	put_device(&hdata->ddc_adpt->dev);
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] crygpu/drm/exynos/exynos_hdmi - Unmap region obtained by of_iomap Arvind Yadav <arvind.yadav.cs@gmail.com> - 2016-10-17 13:20 +0200
  Re: [PATCH] crygpu/drm/exynos/exynos_hdmi - Unmap region obtained by  of_iomap Andrzej Hajda <a.hajda@samsung.com> - 2016-10-17 13:40 +0200

csiph-web