Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1501776 > unrolled thread

Re: linux-4.9-rc1/drivers/staging/lustre/lustre/osc/osc_request.c:973: always false test ?

Started by"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
First post2016-10-17 10:40 +0200
Last post2016-10-17 10:40 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re:  linux-4.9-rc1/drivers/staging/lustre/lustre/osc/osc_request.c:973: always  false test ? "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org> - 2016-10-17 10:40 +0200

#1501776 — Re: linux-4.9-rc1/drivers/staging/lustre/lustre/osc/osc_request.c:973: always false test ?

From"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Date2016-10-17 10:40 +0200
SubjectRe: linux-4.9-rc1/drivers/staging/lustre/lustre/osc/osc_request.c:973: always false test ?
Message-ID<stbCF-15W-9@gated-at.bofh.it>
On Mon, Oct 17, 2016 at 07:33:33AM +0000, David Binderman wrote:
> Hello there,
> 
> 
> 
> linux-4.9-rc1/drivers/staging/lustre/lustre/osc/osc_request.c:973]: (style) Checking if unsigned variable 'cli.cl_avail_grant' is less than zero.
> 
> 
> 
> Source code is
> 
> 
> 
>    if (cli->cl_avail_grant < 0) {
> 
> 
> 
> Suggest code rework.

Great!  Please send a patch.

thanks,

greg k-h

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web