Re: linux-4.9-rc1/drivers/staging/lustre/lustre/osc/osc_request.c:973: always false test ?

From	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: linux-4.9-rc1/drivers/staging/lustre/lustre/osc/osc_request.c:973: always false test ?
Date	2016-10-17 10:40 +0200
Message-ID	<stbCF-15W-9@gated-at.bofh.it> (permalink)
References	<stbCF-15W-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Oct 17, 2016 at 07:33:33AM +0000, David Binderman wrote:
> Hello there,
> 
> 
> 
> linux-4.9-rc1/drivers/staging/lustre/lustre/osc/osc_request.c:973]: (style) Checking if unsigned variable 'cli.cl_avail_grant' is less than zero.
> 
> 
> 
> Source code is
> 
> 
> 
>    if (cli->cl_avail_grant < 0) {
> 
> 
> 
> Suggest code rework.

Great!  Please send a patch.

thanks,

greg k-h

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re:  linux-4.9-rc1/drivers/staging/lustre/lustre/osc/osc_request.c:973: always  false test ? "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org> - 2016-10-17 10:40 +0200

csiph-web