Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1503093 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2016-10-18 17:20 +0200 |
| Last post | 2016-10-19 03:20 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] scsi: g_NCR5380: add HAS_IOPORT_MAP dependency Arnd Bergmann <arnd@arndb.de> - 2016-10-18 17:20 +0200
Re: [PATCH] scsi: g_NCR5380: add HAS_IOPORT_MAP dependency Finn Thain <fthain@telegraphics.com.au> - 2016-10-19 00:40 +0200
Re: [PATCH] scsi: g_NCR5380: add HAS_IOPORT_MAP dependency "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-10-19 03:20 +0200
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-10-18 17:20 +0200 |
| Subject | [PATCH] scsi: g_NCR5380: add HAS_IOPORT_MAP dependency |
| Message-ID | <stElj-3tp-7@gated-at.bofh.it> |
The driver was changed to call ioport_map, which breaks platforms that
cannot provide this function:
drivers/scsi/g_NCR5380.o: In function `generic_NCR5380_init_one.constprop.0':
g_NCR5380.c:(.text.generic_NCR5380_init_one.constprop.0+0x388): undefined reference to `ioport_map'
This adds a Kconfig dependency.
Fixes: 04c40f82ccc5 ("scsi: g_NCR5380: Merge g_NCR5380 and g_NCR5380_mmio drivers")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/scsi/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 98451fe031a4..3b416c9efe5e 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -744,7 +744,7 @@ config SCSI_ISCI
config SCSI_GENERIC_NCR5380
tristate "Generic NCR5380/53c400 SCSI ISA card support"
- depends on ISA && SCSI
+ depends on ISA && SCSI && HAS_IOPORT_MAP
select SCSI_SPI_ATTRS
---help---
This is a driver for old ISA card SCSI controllers based on a
--
2.9.0
[toc] | [next] | [standalone]
| From | Finn Thain <fthain@telegraphics.com.au> |
|---|---|
| Date | 2016-10-19 00:40 +0200 |
| Message-ID | <stLd8-5q-3@gated-at.bofh.it> |
| In reply to | #1503093 |
On Tue, 18 Oct 2016, Arnd Bergmann wrote:
> The driver was changed to call ioport_map, which breaks platforms that
> cannot provide this function:
>
> drivers/scsi/g_NCR5380.o: In function `generic_NCR5380_init_one.constprop.0':
> g_NCR5380.c:(.text.generic_NCR5380_init_one.constprop.0+0x388): undefined reference to `ioport_map'
>
> This adds a Kconfig dependency.
>
> Fixes: 04c40f82ccc5 ("scsi: g_NCR5380: Merge g_NCR5380 and g_NCR5380_mmio drivers")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Finn Thain <fthain@telegraphics.com.au>
> ---
> drivers/scsi/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> index 98451fe031a4..3b416c9efe5e 100644
> --- a/drivers/scsi/Kconfig
> +++ b/drivers/scsi/Kconfig
> @@ -744,7 +744,7 @@ config SCSI_ISCI
>
> config SCSI_GENERIC_NCR5380
> tristate "Generic NCR5380/53c400 SCSI ISA card support"
> - depends on ISA && SCSI
> + depends on ISA && SCSI && HAS_IOPORT_MAP
> select SCSI_SPI_ATTRS
> ---help---
> This is a driver for old ISA card SCSI controllers based on a
>
[toc] | [prev] | [next] | [standalone]
| From | "Martin K. Petersen" <martin.petersen@oracle.com> |
|---|---|
| Date | 2016-10-19 03:20 +0200 |
| Message-ID | <stNHX-1YD-7@gated-at.bofh.it> |
| In reply to | #1503093 |
>>>>> "Arnd" == Arnd Bergmann <arnd@arndb.de> writes: Arnd> The driver was changed to call ioport_map, which breaks platforms Arnd> that cannot provide this function: Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web