Re: [PATCH] scsi: g_NCR5380: add HAS_IOPORT_MAP dependency

From	Finn Thain <fthain@telegraphics.com.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH] scsi: g_NCR5380: add HAS_IOPORT_MAP dependency
Date	2016-10-19 00:40 +0200
Message-ID	<stLd8-5q-3@gated-at.bofh.it> (permalink)
References	<stElj-3tp-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 18 Oct 2016, Arnd Bergmann wrote:

> The driver was changed to call ioport_map, which breaks platforms that
> cannot provide this function:
> 
> drivers/scsi/g_NCR5380.o: In function `generic_NCR5380_init_one.constprop.0':
> g_NCR5380.c:(.text.generic_NCR5380_init_one.constprop.0+0x388): undefined reference to `ioport_map'
> 
> This adds a Kconfig dependency.
> 
> Fixes: 04c40f82ccc5 ("scsi: g_NCR5380: Merge g_NCR5380 and g_NCR5380_mmio drivers")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Finn Thain <fthain@telegraphics.com.au>

> ---
>  drivers/scsi/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> index 98451fe031a4..3b416c9efe5e 100644
> --- a/drivers/scsi/Kconfig
> +++ b/drivers/scsi/Kconfig
> @@ -744,7 +744,7 @@ config SCSI_ISCI
>  
>  config SCSI_GENERIC_NCR5380
>  	tristate "Generic NCR5380/53c400 SCSI ISA card support"
> -	depends on ISA && SCSI
> +	depends on ISA && SCSI && HAS_IOPORT_MAP
>  	select SCSI_SPI_ATTRS
>  	---help---
>  	  This is a driver for old ISA card SCSI controllers based on a
>

Thread

[PATCH] scsi: g_NCR5380: add HAS_IOPORT_MAP dependency Arnd Bergmann <arnd@arndb.de> - 2016-10-18 17:20 +0200
  Re: [PATCH] scsi: g_NCR5380: add HAS_IOPORT_MAP dependency Finn Thain <fthain@telegraphics.com.au> - 2016-10-19 00:40 +0200
  Re: [PATCH] scsi: g_NCR5380: add HAS_IOPORT_MAP dependency "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-10-19 03:20 +0200

csiph-web