Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1502753 > unrolled thread
| Started by | Niklas Cassel <niklas.cassel@axis.com> |
|---|---|
| First post | 2016-10-18 09:30 +0200 |
| Last post | 2016-10-18 16:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v2 1/2] dwc_eth_qos: do not clear pause flags from phy_device->supported Niklas Cassel <niklas.cassel@axis.com> - 2016-10-18 09:30 +0200
Re: [PATCH v2 1/2] dwc_eth_qos: do not clear pause flags from phy_device->supported David Miller <davem@davemloft.net> - 2016-10-18 16:40 +0200
| From | Niklas Cassel <niklas.cassel@axis.com> |
|---|---|
| Date | 2016-10-18 09:30 +0200 |
| Subject | [PATCH v2 1/2] dwc_eth_qos: do not clear pause flags from phy_device->supported |
| Message-ID | <stx0t-70j-13@gated-at.bofh.it> |
From: Niklas Cassel <niklas.cassel@axis.com> phy_device->supported is originally set by the PHY driver. The ethernet driver should filter phy_device->supported to only contain flags supported by the IP. The IP supports setting rx and tx flow control independently, therefore SUPPORTED_Pause and SUPPORTED_Asym_Pause should not be cleared. If the flags are cleared, pause frames cannot be enabled (even if they are supported by the PHY). Signed-off-by: Niklas Cassel <niklas.cassel@axis.com> Signed-off-by: Jesper Nilsson <jespern@axis.com> Acked-by: Lars Persson <larper@axis.com> --- drivers/net/ethernet/synopsys/dwc_eth_qos.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/synopsys/dwc_eth_qos.c b/drivers/net/ethernet/synopsys/dwc_eth_qos.c index 0d0053128542..d775729648ef 100644 --- a/drivers/net/ethernet/synopsys/dwc_eth_qos.c +++ b/drivers/net/ethernet/synopsys/dwc_eth_qos.c @@ -982,7 +982,8 @@ static int dwceqos_mii_probe(struct net_device *ndev) if (netif_msg_probe(lp)) phy_attached_info(phydev); - phydev->supported &= PHY_GBIT_FEATURES; + phydev->supported &= PHY_GBIT_FEATURES | SUPPORTED_Pause | + SUPPORTED_Asym_Pause; lp->link = 0; lp->speed = 0; -- 2.1.4
[toc] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2016-10-18 16:40 +0200 |
| Subject | Re: [PATCH v2 1/2] dwc_eth_qos: do not clear pause flags from phy_device->supported |
| Message-ID | <stDIC-2X6-39@gated-at.bofh.it> |
| In reply to | #1502753 |
From: Niklas Cassel <niklas.cassel@axis.com> Date: Tue, 18 Oct 2016 09:20:33 +0200 > From: Niklas Cassel <niklas.cassel@axis.com> > > phy_device->supported is originally set by the PHY driver. > The ethernet driver should filter phy_device->supported to only contain > flags supported by the IP. > The IP supports setting rx and tx flow control independently, > therefore SUPPORTED_Pause and SUPPORTED_Asym_Pause should not be cleared. > If the flags are cleared, pause frames cannot be enabled (even if they > are supported by the PHY). > > Signed-off-by: Niklas Cassel <niklas.cassel@axis.com> > Signed-off-by: Jesper Nilsson <jespern@axis.com> > Acked-by: Lars Persson <larper@axis.com> Applied.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web