Re: [PATCH v2 1/2] dwc_eth_qos: do not clear pause flags from phy_device->supported

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/2] dwc_eth_qos: do not clear pause flags from phy_device->supported
Date	2016-10-18 16:40 +0200
Message-ID	<stDIC-2X6-39@gated-at.bofh.it> (permalink)
References	<stx0t-70j-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Niklas Cassel <niklas.cassel@axis.com>
Date: Tue, 18 Oct 2016 09:20:33 +0200

> From: Niklas Cassel <niklas.cassel@axis.com>
> 
> phy_device->supported is originally set by the PHY driver.
> The ethernet driver should filter phy_device->supported to only contain
> flags supported by the IP.
> The IP supports setting rx and tx flow control independently,
> therefore SUPPORTED_Pause and SUPPORTED_Asym_Pause should not be cleared.
> If the flags are cleared, pause frames cannot be enabled (even if they
> are supported by the PHY).
> 
> Signed-off-by: Niklas Cassel <niklas.cassel@axis.com>
> Signed-off-by: Jesper Nilsson <jespern@axis.com>
> Acked-by: Lars Persson <larper@axis.com>

Applied.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/2] dwc_eth_qos: do not clear pause flags from phy_device->supported Niklas Cassel <niklas.cassel@axis.com> - 2016-10-18 09:30 +0200
  Re: [PATCH v2 1/2] dwc_eth_qos: do not clear pause flags from  phy_device->supported David Miller <davem@davemloft.net> - 2016-10-18 16:40 +0200

csiph-web