Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1499134 > unrolled thread
| Started by | Carlos Palminha <CARLOS.PALMINHA@synopsys.com> |
|---|---|
| First post | 2016-10-11 20:30 +0200 |
| Last post | 2016-10-13 18:50 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 0/5] i2c: i2c-piix4: set of coding style fixes Carlos Palminha <CARLOS.PALMINHA@synopsys.com> - 2016-10-11 20:30 +0200
Re: [PATCH 0/5] i2c: i2c-piix4: set of coding style fixes Jean Delvare <jdelvare@suse.de> - 2016-10-13 13:50 +0200
Re: [PATCH 0/5] i2c: i2c-piix4: set of coding style fixes Carlos Palminha <CARLOS.PALMINHA@synopsys.com> - 2016-10-13 18:50 +0200
| From | Carlos Palminha <CARLOS.PALMINHA@synopsys.com> |
|---|---|
| Date | 2016-10-11 20:30 +0200 |
| Subject | [PATCH 0/5] i2c: i2c-piix4: set of coding style fixes |
| Message-ID | <sr92h-15w-13@gated-at.bofh.it> |
This patchset fixes several coding style issues. Carlos Palminha (5): i2c: i2c-piix4: coding style fix - '*' adjacent to data name i2c: i2c-piix4: coding style fix - assignment in if condition i2c: i2c-piix4: coding style fix - long comments blocks i2c: i2c-piix4: coding style fix - spaces with open parenthesis i2c: i2c-piix4: coding style fix - quoted string split across lines drivers/i2c/busses/i2c-piix4.c | 144 +++++++++++++++++++++++------------------ 1 file changed, 82 insertions(+), 62 deletions(-) -- 2.9.3
[toc] | [next] | [standalone]
| From | Jean Delvare <jdelvare@suse.de> |
|---|---|
| Date | 2016-10-13 13:50 +0200 |
| Message-ID | <srMGn-30B-47@gated-at.bofh.it> |
| In reply to | #1499134 |
Hi Carlos, On Tue, 11 Oct 2016 18:24:36 +0100, Carlos Palminha wrote: > This patchset fixes several coding style issues. > > Carlos Palminha (5): > i2c: i2c-piix4: coding style fix - '*' adjacent to data name > i2c: i2c-piix4: coding style fix - assignment in if condition > i2c: i2c-piix4: coding style fix - long comments blocks > i2c: i2c-piix4: coding style fix - spaces with open parenthesis > i2c: i2c-piix4: coding style fix - quoted string split across lines > > drivers/i2c/busses/i2c-piix4.c | 144 +++++++++++++++++++++++------------------ > 1 file changed, 82 insertions(+), 62 deletions(-) Except for the two issues which were already pointed out, I'm fine with these changes, however there is no good reason to split them into 5 separate patches. Fixing the coding style is one goal, it should be all done with a single patch. So, when you resubmit, please do so as a single patch. Thanks, -- Jean Delvare SUSE L3 Support
[toc] | [prev] | [next] | [standalone]
| From | Carlos Palminha <CARLOS.PALMINHA@synopsys.com> |
|---|---|
| Date | 2016-10-13 18:50 +0200 |
| Message-ID | <srRmF-5Xf-7@gated-at.bofh.it> |
| In reply to | #1500215 |
Hi Jean, On 13-10-2016 12:40, Jean Delvare wrote: > Hi Carlos, > > On Tue, 11 Oct 2016 18:24:36 +0100, Carlos Palminha wrote: >> This patchset fixes several coding style issues. >> >> Carlos Palminha (5): >> i2c: i2c-piix4: coding style fix - '*' adjacent to data name >> i2c: i2c-piix4: coding style fix - assignment in if condition >> i2c: i2c-piix4: coding style fix - long comments blocks >> i2c: i2c-piix4: coding style fix - spaces with open parenthesis >> i2c: i2c-piix4: coding style fix - quoted string split across lines >> >> drivers/i2c/busses/i2c-piix4.c | 144 +++++++++++++++++++++++------------------ >> 1 file changed, 82 insertions(+), 62 deletions(-) > > Except for the two issues which were already pointed out, I'm fine with > these changes, however there is no good reason to split them into 5 > separate patches. Fixing the coding style is one goal, it should be all > done with a single patch. So, when you resubmit, please do so as a > single patch. > > Thanks, > Sure... I'll resubmit as one patch. Regards, C.Palminha
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web