Re: [PATCH 0/5] i2c: i2c-piix4: set of coding style fixes

From	Carlos Palminha <CARLOS.PALMINHA@synopsys.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/5] i2c: i2c-piix4: set of coding style fixes
Date	2016-10-13 18:50 +0200
Message-ID	<srRmF-5Xf-7@gated-at.bofh.it> (permalink)
References	<sr92h-15w-13@gated-at.bofh.it> <srMGn-30B-47@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Jean,

On 13-10-2016 12:40, Jean Delvare wrote:
> Hi Carlos,
> 
> On Tue, 11 Oct 2016 18:24:36 +0100, Carlos Palminha wrote:
>> This patchset fixes several coding style issues.
>>
>> Carlos Palminha (5):
>>   i2c: i2c-piix4: coding style fix - '*' adjacent to data name
>>   i2c: i2c-piix4: coding style fix - assignment in if condition
>>   i2c: i2c-piix4: coding style fix - long comments blocks
>>   i2c: i2c-piix4: coding style fix - spaces with open parenthesis
>>   i2c: i2c-piix4: coding style fix - quoted string split across lines
>>
>>  drivers/i2c/busses/i2c-piix4.c | 144 +++++++++++++++++++++++------------------
>>  1 file changed, 82 insertions(+), 62 deletions(-)
> 
> Except for the two issues which were already pointed out, I'm fine with
> these changes, however there is no good reason to split them into 5
> separate patches. Fixing the coding style is one goal, it should be all
> done with a single patch. So, when you resubmit, please do so as a
> single patch.
> 
> Thanks,
> 

Sure... I'll resubmit as one patch.

Regards,
C.Palminha

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] i2c: i2c-piix4: set of coding style fixes  Carlos Palminha <CARLOS.PALMINHA@synopsys.com> - 2016-10-11 20:30 +0200
  Re: [PATCH 0/5] i2c: i2c-piix4: set of coding style fixes Jean Delvare <jdelvare@suse.de> - 2016-10-13 13:50 +0200
    Re: [PATCH 0/5] i2c: i2c-piix4: set of coding style fixes Carlos Palminha <CARLOS.PALMINHA@synopsys.com> - 2016-10-13 18:50 +0200

csiph-web