Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1500283 > unrolled thread
| Started by | David Miller <davem@davemloft.net> |
|---|---|
| First post | 2016-10-13 16:00 +0200 |
| Last post | 2016-10-14 02:10 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] qed: fix old-style function definition David Miller <davem@davemloft.net> - 2016-10-13 16:00 +0200
Re: [PATCH] qed: fix old-style function definition David Miller <davem@davemloft.net> - 2016-10-13 17:00 +0200
RE: [PATCH] qed: fix old-style function definition "Mintz, Yuval" <Yuval.Mintz@cavium.com> - 2016-10-14 02:10 +0200
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2016-10-13 16:00 +0200 |
| Subject | Re: [PATCH] qed: fix old-style function definition |
| Message-ID | <srOI9-4cr-13@gated-at.bofh.it> |
From: Arnd Bergmann <arnd@arndb.de>
Date: Mon, 10 Oct 2016 13:59:16 +0200
> The definition of qed_get_rdma_ops() is not a prototype unless
> we add 'void' here, as indicated by this W=1 warning:
>
> drivers/net/ethernet/qlogic/qed/qed_roce.c: In function ‘qed_get_rdma_ops’:
> drivers/net/ethernet/qlogic/qed/qed_roce.c:2950:28: error: old-style function definition [-Werror=old-style-definition]
>
> Fixes: abd49676c707 ("qed: Add RoCE ll2 & GSI support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Again, Qlogic folks, please properly review patches posted against your
driver.
Thanks.
[toc] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2016-10-13 17:00 +0200 |
| Message-ID | <srPEe-4Qo-15@gated-at.bofh.it> |
| In reply to | #1500283 |
From: "Mintz, Yuval" <Yuval.Mintz@cavium.com>
Date: Thu, 13 Oct 2016 14:15:51 +0000
>> > The definition of qed_get_rdma_ops() is not a prototype unless we add
>> > 'void' here, as indicated by this W=1 warning:
>> >
>> > drivers/net/ethernet/qlogic/qed/qed_roce.c: In function ‘qed_get_rdma_ops’:
>> > drivers/net/ethernet/qlogic/qed/qed_roce.c:2950:28: error: old-style
>> > function definition [-Werror=old-style-definition]
>> >
>> > Fixes: abd49676c707 ("qed: Add RoCE ll2 & GSI support")
>> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>
>> Again, Qlogic folks, please properly review patches posted against your driver.
>>
>> Thanks.
>
> Sorry, managed to miss this one.
> Acked-by: Yuval Mintz <Yuval.Mintz@caviumnetworks.com>
Applied.
[toc] | [prev] | [next] | [standalone]
| From | "Mintz, Yuval" <Yuval.Mintz@cavium.com> |
|---|---|
| Date | 2016-10-14 02:10 +0200 |
| Message-ID | <srPEe-4Qo-17@gated-at.bofh.it> |
| In reply to | #1500283 |
> > The definition of qed_get_rdma_ops() is not a prototype unless we add
> > 'void' here, as indicated by this W=1 warning:
> >
> > drivers/net/ethernet/qlogic/qed/qed_roce.c: In function ‘qed_get_rdma_ops’:
> > drivers/net/ethernet/qlogic/qed/qed_roce.c:2950:28: error: old-style
> > function definition [-Werror=old-style-definition]
> >
> > Fixes: abd49676c707 ("qed: Add RoCE ll2 & GSI support")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Again, Qlogic folks, please properly review patches posted against your driver.
>
> Thanks.
Sorry, managed to miss this one.
Acked-by: Yuval Mintz <Yuval.Mintz@caviumnetworks.com>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web