Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1500639

RE: [PATCH] qed: fix old-style function definition

From "Mintz, Yuval" <Yuval.Mintz@cavium.com>
Newsgroups linux.kernel
Subject RE: [PATCH] qed: fix old-style function definition
Date 2016-10-14 02:10 +0200
Message-ID <srPEe-4Qo-17@gated-at.bofh.it> (permalink)
References <sqHz5-16x-47@gated-at.bofh.it> <srOI9-4cr-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


> > The definition of qed_get_rdma_ops() is not a prototype unless we add
> > 'void' here, as indicated by this W=1 warning:
> >
> > drivers/net/ethernet/qlogic/qed/qed_roce.c: In function ‘qed_get_rdma_ops’:
> > drivers/net/ethernet/qlogic/qed/qed_roce.c:2950:28: error: old-style
> > function definition [-Werror=old-style-definition]
> >
> > Fixes: abd49676c707 ("qed: Add RoCE ll2 & GSI support")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> Again, Qlogic folks, please properly review patches posted against your driver.
> 
> Thanks.

Sorry, managed to miss this one.
Acked-by: Yuval Mintz <Yuval.Mintz@caviumnetworks.com>

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

Re: [PATCH] qed: fix old-style function definition David Miller <davem@davemloft.net> - 2016-10-13 16:00 +0200
  Re: [PATCH] qed: fix old-style function definition David Miller <davem@davemloft.net> - 2016-10-13 17:00 +0200
  RE: [PATCH] qed: fix old-style function definition "Mintz, Yuval" <Yuval.Mintz@cavium.com> - 2016-10-14 02:10 +0200

csiph-web