Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1496666 > unrolled thread
| Started by | Geert Uytterhoeven <geert@linux-m68k.org> |
|---|---|
| First post | 2016-10-06 16:00 +0200 |
| Last post | 2016-10-06 16:50 +0200 |
| Articles | 5 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA Geert Uytterhoeven <geert@linux-m68k.org> - 2016-10-06 16:00 +0200
Re: [PATCH] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA Timur Tabi <timur@codeaurora.org> - 2016-10-06 16:10 +0200
Re: [PATCH] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA Geert Uytterhoeven <geert@linux-m68k.org> - 2016-10-06 16:20 +0200
Re: [PATCH] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA Timur Tabi <timur@codeaurora.org> - 2016-10-06 16:20 +0200
Re: [PATCH] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA Geert Uytterhoeven <geert@linux-m68k.org> - 2016-10-06 16:50 +0200
| From | Geert Uytterhoeven <geert@linux-m68k.org> |
|---|---|
| Date | 2016-10-06 16:00 +0200 |
| Subject | [PATCH] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA |
| Message-ID | <sphnj-Oy-7@gated-at.bofh.it> |
If NO_DMA=y:
drivers/built-in.o: In function `emac_probe':
emac.c:(.text+0x3780b8): undefined reference to `bad_dma_ops'
emac.c:(.text+0x3780e2): undefined reference to `bad_dma_ops'
emac.c:(.text+0x378112): undefined reference to `bad_dma_ops'
emac.c:(.text+0x378146): undefined reference to `bad_dma_ops'
emac.c:(.text+0x37816e): undefined reference to `bad_dma_ops'
drivers/built-in.o:emac.c:(.text+0x37819a): more undefined references to `bad_dma_ops' follow
Add a dependency on HAS_DMA to fix this.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/net/ethernet/qualcomm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/qualcomm/Kconfig b/drivers/net/ethernet/qualcomm/Kconfig
index 9ba568db576fb0e6..fe94d2baeaf26aa6 100644
--- a/drivers/net/ethernet/qualcomm/Kconfig
+++ b/drivers/net/ethernet/qualcomm/Kconfig
@@ -26,6 +26,7 @@ config QCA7000
config QCOM_EMAC
tristate "Qualcomm Technologies, Inc. EMAC Gigabit Ethernet support"
+ depends on HAS_DMA
select CRC32
select PHYLIB
---help---
--
1.9.1
[toc] | [next] | [standalone]
| From | Timur Tabi <timur@codeaurora.org> |
|---|---|
| Date | 2016-10-06 16:10 +0200 |
| Message-ID | <sphwZ-18h-9@gated-at.bofh.it> |
| In reply to | #1496666 |
Geert Uytterhoeven wrote:
> config QCOM_EMAC
> tristate "Qualcomm Technologies, Inc. EMAC Gigabit Ethernet support"
> + depends on HAS_DMA
I think it needs to depend on HAS_IOMEM as well, to fix this error in
arch/um:
drivers/net/ethernet/qualcomm/emac/emac.c: In function 'emac_remove':
>> drivers/net/ethernet/qualcomm/emac/emac.c:727:3: error: implicit
declaration of function 'iounmap' [-Werror=implicit-function-declaration]
iounmap(adpt->phy.digital);
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
[toc] | [prev] | [next] | [standalone]
| From | Geert Uytterhoeven <geert@linux-m68k.org> |
|---|---|
| Date | 2016-10-06 16:20 +0200 |
| Message-ID | <sphGF-1fG-1@gated-at.bofh.it> |
| In reply to | #1496672 |
On Thu, Oct 6, 2016 at 4:06 PM, Timur Tabi <timur@codeaurora.org> wrote:
> Geert Uytterhoeven wrote:
>>
>> config QCOM_EMAC
>> tristate "Qualcomm Technologies, Inc. EMAC Gigabit Ethernet
>> support"
>> + depends on HAS_DMA
>
>
> I think it needs to depend on HAS_IOMEM as well, to fix this error in
> arch/um:
>
> drivers/net/ethernet/qualcomm/emac/emac.c: In function 'emac_remove':
>>> drivers/net/ethernet/qualcomm/emac/emac.c:727:3: error: implicit
>>> declaration of function 'iounmap' [-Werror=implicit-function-declaration]
> iounmap(adpt->phy.digital);
Probably, I don't do UML allmodconfig builds.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
[toc] | [prev] | [next] | [standalone]
| From | Timur Tabi <timur@codeaurora.org> |
|---|---|
| Date | 2016-10-06 16:20 +0200 |
| Message-ID | <sphGG-1fG-25@gated-at.bofh.it> |
| In reply to | #1496676 |
Geert Uytterhoeven wrote:
> Probably, I don't do UML allmodconfig builds.
>
> Gr{oetje,eeting}s,
Would you mind submitting another version of your patch that includes
HAS_DMA and HAS_IOMEM, so that both build breaks can be fixed in one shot?
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
[toc] | [prev] | [next] | [standalone]
| From | Geert Uytterhoeven <geert@linux-m68k.org> |
|---|---|
| Date | 2016-10-06 16:50 +0200 |
| Message-ID | <spi9I-1qA-7@gated-at.bofh.it> |
| In reply to | #1496679 |
On Thu, Oct 6, 2016 at 4:12 PM, Timur Tabi <timur@codeaurora.org> wrote:
> Geert Uytterhoeven wrote:
>>
>> Probably, I don't do UML allmodconfig builds.
>>
>> Gr{oetje,eeting}s,
>
>
> Would you mind submitting another version of your patch that includes
> HAS_DMA and HAS_IOMEM, so that both build breaks can be fixed in one shot?
Done.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web