Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1496672

Re: [PATCH] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA

From Timur Tabi <timur@codeaurora.org>
Newsgroups linux.kernel
Subject Re: [PATCH] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA
Date 2016-10-06 16:10 +0200
Message-ID <sphwZ-18h-9@gated-at.bofh.it> (permalink)
References <sphnj-Oy-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Geert Uytterhoeven wrote:
>   config QCOM_EMAC
>   	tristate "Qualcomm Technologies, Inc. EMAC Gigabit Ethernet support"
> +	depends on HAS_DMA

I think it needs to depend on HAS_IOMEM as well, to fix this error in 
arch/um:

    drivers/net/ethernet/qualcomm/emac/emac.c: In function 'emac_remove':
 >> drivers/net/ethernet/qualcomm/emac/emac.c:727:3: error: implicit 
declaration of function 'iounmap' [-Werror=implicit-function-declaration]
       iounmap(adpt->phy.digital);

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA Geert Uytterhoeven <geert@linux-m68k.org> - 2016-10-06 16:00 +0200
  Re: [PATCH] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA Timur Tabi <timur@codeaurora.org> - 2016-10-06 16:10 +0200
    Re: [PATCH] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA Geert Uytterhoeven <geert@linux-m68k.org> - 2016-10-06 16:20 +0200
      Re: [PATCH] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA Timur Tabi <timur@codeaurora.org> - 2016-10-06 16:20 +0200
        Re: [PATCH] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA Geert Uytterhoeven <geert@linux-m68k.org> - 2016-10-06 16:50 +0200

csiph-web