Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1494297 > unrolled thread

[PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit coding style issue

Back to article view | Back to linux.kernel

Contents

  [PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit coding  style issue Nadim Almas <nadim.902@gmail.com> - 2016-09-30 23:50 +0200
    Re: [PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit  coding style issue Greg KH <gregkh@linuxfoundation.org> - 2016-10-02 17:30 +0200
      Fwd: [PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit  coding style issue Nadim Almas <nadim.902@gmail.com> - 2016-10-02 17:50 +0200
        Re: Fwd: [PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line  limit coding style issue Greg KH <gregkh@linuxfoundation.org> - 2016-10-02 18:10 +0200
          Re: Fwd: [PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit  coding style issue Nadim Almas <nadim.902@gmail.com> - 2016-10-02 18:50 +0200
            Re: Fwd: [PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line  limit coding style issue Greg KH <gregkh@linuxfoundation.org> - 2016-10-02 19:50 +0200

#1494297 — [PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit coding style issue

Fixed coding style issue.

Signed-off-by: Nadim Almas <nadim.902@gmail.com>
---
 drivers/staging/dgnc/dgnc_neo.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c
index e794056..bc15584 100644
--- a/drivers/staging/dgnc/dgnc_neo.c
+++ b/drivers/staging/dgnc/dgnc_neo.c
@@ -554,7 +554,8 @@ static inline void neo_parse_lsr(struct dgnc_board *brd, uint port)
 		 * Rx Oruns. Exar says that an orun will NOT corrupt
 		 * the FIFO. It will just replace the holding register
 		 * with this new data byte. So basically just ignore this.
-		 * Probably we should eventually have an orun stat in our driver...
+		 * Probably we should eventually have an orun stat in our
+		 * driver...
 		 */
 		ch->ch_err_overrun++;
 	}
-- 
2.7.4

[toc] | [next] | [standalone]

#1494587 — Re: [PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit coding style issue

On Fri, Sep 30, 2016 at 02:49:12PM -0700, Nadim Almas wrote:
> Fixed coding style issue.
> 
> Signed-off-by: Nadim Almas <nadim.902@gmail.com>
> ---
>  drivers/staging/dgnc/dgnc_neo.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c
> index e794056..bc15584 100644
> --- a/drivers/staging/dgnc/dgnc_neo.c
> +++ b/drivers/staging/dgnc/dgnc_neo.c
> @@ -554,7 +554,8 @@ static inline void neo_parse_lsr(struct dgnc_board *brd, uint port)
>  		 * Rx Oruns. Exar says that an orun will NOT corrupt
>  		 * the FIFO. It will just replace the holding register
>  		 * with this new data byte. So basically just ignore this.
> -		 * Probably we should eventually have an orun stat in our driver...
> +		 * Probably we should eventually have an orun stat in our
> +		 * driver...
>  		 */
>  		ch->ch_err_overrun++;
>  	}

Why did you just fix only one of these warnings in the file?  You aren't
going to send one patch per instance of this warning in this file, are
you?  Please group it all into one.

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1494589 — Fwd: [PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit coding style issue

sir i am  new in linux kernel hacking so I just want to start with
something very simple ,so for sake of simplicity and learning I fixed
only one of these warning

[toc] | [prev] | [next] | [standalone]

#1494592 — Re: Fwd: [PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit coding style issue

On Sun, Oct 02, 2016 at 09:13:32PM +0530, Nadim Almas wrote:
> sir i am  new in linux kernel hacking so I just want to start with
> something very simple ,so for sake of simplicity and learning I fixed
> only one of these warning

That's great, but next time try to do a little bit more, just fixing a
single warning like that isn't all that useful overall, right?

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1494595 — Re: Fwd: [PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit coding style issue

So my first patch is correct?

On Sun, Oct 2, 2016 at 9:39 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Sun, Oct 02, 2016 at 09:13:32PM +0530, Nadim Almas wrote:
>> sir i am  new in linux kernel hacking so I just want to start with
>> something very simple ,so for sake of simplicity and learning I fixed
>> only one of these warning
>
> That's great, but next time try to do a little bit more, just fixing a
> single warning like that isn't all that useful overall, right?
>
> thanks,
>
> greg k-h

[toc] | [prev] | [next] | [standalone]

#1494599 — Re: Fwd: [PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit coding style issue

A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?


http://daringfireball.net/2007/07/on_top

On Sun, Oct 02, 2016 at 10:11:12PM +0530, Nadim Almas wrote:
> So my first patch is correct?

I don't remember, I think someone else already did the same work as you,
but as I deal with hundreds of patches a day, I can't recall.  Resync on
my staging-testing branch of staging.git and rebase your patch and do
more cleanup than just one tiny one and then resend.

thanks,

greg k-h

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web