Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1494587

Re: [PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit coding style issue

Show all headers | View raw

On Fri, Sep 30, 2016 at 02:49:12PM -0700, Nadim Almas wrote:
> Fixed coding style issue.
> 
> Signed-off-by: Nadim Almas <nadim.902@gmail.com>
> ---
>  drivers/staging/dgnc/dgnc_neo.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c
> index e794056..bc15584 100644
> --- a/drivers/staging/dgnc/dgnc_neo.c
> +++ b/drivers/staging/dgnc/dgnc_neo.c
> @@ -554,7 +554,8 @@ static inline void neo_parse_lsr(struct dgnc_board *brd, uint port)
>  		 * Rx Oruns. Exar says that an orun will NOT corrupt
>  		 * the FIFO. It will just replace the holding register
>  		 * with this new data byte. So basically just ignore this.
> -		 * Probably we should eventually have an orun stat in our driver...
> +		 * Probably we should eventually have an orun stat in our
> +		 * driver...
>  		 */
>  		ch->ch_err_overrun++;
>  	}

Why did you just fix only one of these warnings in the file?  You aren't
going to send one patch per instance of this warning in this file, are
you?  Please group it all into one.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit coding  style issue Nadim Almas <nadim.902@gmail.com> - 2016-09-30 23:50 +0200
  Re: [PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit  coding style issue Greg KH <gregkh@linuxfoundation.org> - 2016-10-02 17:30 +0200
    Fwd: [PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit  coding style issue Nadim Almas <nadim.902@gmail.com> - 2016-10-02 17:50 +0200
      Re: Fwd: [PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line  limit coding style issue Greg KH <gregkh@linuxfoundation.org> - 2016-10-02 18:10 +0200
        Re: Fwd: [PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line limit  coding style issue Nadim Almas <nadim.902@gmail.com> - 2016-10-02 18:50 +0200
          Re: Fwd: [PATCH] Staging:dgnc:dgnc_neo: fixed 80 character line  limit coding style issue Greg KH <gregkh@linuxfoundation.org> - 2016-10-02 19:50 +0200

csiph-web