Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1492781 > unrolled thread
| Started by | Moritz Fischer <moritz.fischer@ettus.com> |
|---|---|
| First post | 2016-09-28 19:10 +0200 |
| Last post | 2016-10-04 15:30 +0200 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH 1/3] Docs: DT: Add National Instruments vendor prefix Moritz Fischer <moritz.fischer@ettus.com> - 2016-09-28 19:10 +0200
[PATCH 3/3] mfd: cros_ec_spi: Add compatible string for NI version of cros-ec-spi Moritz Fischer <moritz.fischer@ettus.com> - 2016-09-28 19:10 +0200
Re: [PATCH 3/3] mfd: cros_ec_spi: Add compatible string for NI version of cros-ec-spi Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-09-28 19:30 +0200
Re: [PATCH 3/3] mfd: cros_ec_spi: Add compatible string for NI version of cros-ec-spi Moritz Fischer <moritz.fischer@ettus.com> - 2016-09-28 19:40 +0200
Re: [PATCH 1/3] Docs: DT: Add National Instruments vendor prefix Rob Herring <robh@kernel.org> - 2016-10-04 15:30 +0200
| From | Moritz Fischer <moritz.fischer@ettus.com> |
|---|---|
| Date | 2016-09-28 19:10 +0200 |
| Subject | [PATCH 1/3] Docs: DT: Add National Instruments vendor prefix |
| Message-ID | <smqwN-18p-9@gated-at.bofh.it> |
Add National Instruments (ni) vendor prefix to list of vendor prefixes Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com> --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt index 1992aa9..a92f62b 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.txt +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt @@ -179,6 +179,7 @@ netlogic Broadcom Corporation (formerly NetLogic Microsystems) netxeon Shenzhen Netxeon Technology CO., LTD newhaven Newhaven Display International nintendo Nintendo +ni National Instruments Corp nokia Nokia nuvoton Nuvoton Technology Corporation nvidia NVIDIA -- 2.7.4
[toc] | [next] | [standalone]
| From | Moritz Fischer <moritz.fischer@ettus.com> |
|---|---|
| Date | 2016-09-28 19:10 +0200 |
| Subject | [PATCH 3/3] mfd: cros_ec_spi: Add compatible string for NI version of cros-ec-spi |
| Message-ID | <smqwN-18p-17@gated-at.bofh.it> |
| In reply to | #1492781 |
Add compatible string for NI version of cros-ec-spi.
Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com>
---
drivers/mfd/cros_ec_spi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mfd/cros_ec_spi.c b/drivers/mfd/cros_ec_spi.c
index ebe9b94..e4504ec 100644
--- a/drivers/mfd/cros_ec_spi.c
+++ b/drivers/mfd/cros_ec_spi.c
@@ -708,6 +708,7 @@ static SIMPLE_DEV_PM_OPS(cros_ec_spi_pm_ops, cros_ec_spi_suspend,
cros_ec_spi_resume);
static const struct of_device_id cros_ec_spi_of_match[] = {
+ { .compatible = "ni,cros-ec-spi", },
{ .compatible = "google,cros-ec-spi", },
{ /* sentinel */ },
};
--
2.7.4
[toc] | [prev] | [next] | [standalone]
| From | Dmitry Torokhov <dmitry.torokhov@gmail.com> |
|---|---|
| Date | 2016-09-28 19:30 +0200 |
| Subject | Re: [PATCH 3/3] mfd: cros_ec_spi: Add compatible string for NI version of cros-ec-spi |
| Message-ID | <smqQ9-1fd-1@gated-at.bofh.it> |
| In reply to | #1492782 |
On Wed, Sep 28, 2016 at 9:59 AM, Moritz Fischer
<moritz.fischer@ettus.com> wrote:
> Add compatible string for NI version of cros-ec-spi.
>
> Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com>
> ---
> drivers/mfd/cros_ec_spi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/cros_ec_spi.c b/drivers/mfd/cros_ec_spi.c
> index ebe9b94..e4504ec 100644
> --- a/drivers/mfd/cros_ec_spi.c
> +++ b/drivers/mfd/cros_ec_spi.c
> @@ -708,6 +708,7 @@ static SIMPLE_DEV_PM_OPS(cros_ec_spi_pm_ops, cros_ec_spi_suspend,
> cros_ec_spi_resume);
>
> static const struct of_device_id cros_ec_spi_of_match[] = {
> + { .compatible = "ni,cros-ec-spi", },
I am confused: if the 2 controllers are the same, why do we need the
new compat string, at least in the driver? Shouldn't DTS simply use
"google,cros-ec-spi", or maybe both (compatible = "ni,cros-ec-spi",
"google,cros-ec-spi")?
DT folks, is there clear instructions somewhere as to when
introduction of new compatible is warranted, along with the rules of
how to settle on common fallback (i.e. how to make sure that, let's
say, Linux, U-boot and FreeBSD use the same fallback compatible for
the same series of devices)?
> { .compatible = "google,cros-ec-spi", },
> { /* sentinel */ },
> };
> --
> 2.7.4
>
Thanks.
--
Dmitry
[toc] | [prev] | [next] | [standalone]
| From | Moritz Fischer <moritz.fischer@ettus.com> |
|---|---|
| Date | 2016-09-28 19:40 +0200 |
| Subject | Re: [PATCH 3/3] mfd: cros_ec_spi: Add compatible string for NI version of cros-ec-spi |
| Message-ID | <smqZP-1iH-11@gated-at.bofh.it> |
| In reply to | #1492790 |
Dmitry,
On Wed, Sep 28, 2016 at 10:27 AM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> On Wed, Sep 28, 2016 at 9:59 AM, Moritz Fischer
> <moritz.fischer@ettus.com> wrote:
>> Add compatible string for NI version of cros-ec-spi.
>>
>> Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com>
>> ---
>> drivers/mfd/cros_ec_spi.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mfd/cros_ec_spi.c b/drivers/mfd/cros_ec_spi.c
>> index ebe9b94..e4504ec 100644
>> --- a/drivers/mfd/cros_ec_spi.c
>> +++ b/drivers/mfd/cros_ec_spi.c
>> @@ -708,6 +708,7 @@ static SIMPLE_DEV_PM_OPS(cros_ec_spi_pm_ops, cros_ec_spi_suspend,
>> cros_ec_spi_resume);
>>
>> static const struct of_device_id cros_ec_spi_of_match[] = {
>> + { .compatible = "ni,cros-ec-spi", },
>
> I am confused: if the 2 controllers are the same, why do we need the
> new compat string, at least in the driver? Shouldn't DTS simply use
> "google,cros-ec-spi", or maybe both (compatible = "ni,cros-ec-spi",
> "google,cros-ec-spi")?
It might deviate in the future, but you're right, the driver patch is
not required for now
since we can use the fallback mechanism until there really *is* a
difference. We can probably
drop this one for now.
Cheers,
Moritz
[toc] | [prev] | [next] | [standalone]
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Date | 2016-10-04 15:30 +0200 |
| Message-ID | <soxXb-3fH-1@gated-at.bofh.it> |
| In reply to | #1492781 |
On Wed, Sep 28, 2016 at 09:59:19AM -0700, Moritz Fischer wrote: > Add National Instruments (ni) vendor prefix to list of > vendor prefixes > > Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com> > --- > Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt > index 1992aa9..a92f62b 100644 > --- a/Documentation/devicetree/bindings/vendor-prefixes.txt > +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt > @@ -179,6 +179,7 @@ netlogic Broadcom Corporation (formerly NetLogic Microsystems) > netxeon Shenzhen Netxeon Technology CO., LTD > newhaven Newhaven Display International > nintendo Nintendo > +ni National Instruments Corp ni comes before nintendo. > nokia Nokia > nuvoton Nuvoton Technology Corporation > nvidia NVIDIA > -- > 2.7.4 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web