Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1492790

Re: [PATCH 3/3] mfd: cros_ec_spi: Add compatible string for NI version of cros-ec-spi

Show all headers | View raw

On Wed, Sep 28, 2016 at 9:59 AM, Moritz Fischer
<moritz.fischer@ettus.com> wrote:
> Add compatible string for NI version of cros-ec-spi.
>
> Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com>
> ---
>  drivers/mfd/cros_ec_spi.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/cros_ec_spi.c b/drivers/mfd/cros_ec_spi.c
> index ebe9b94..e4504ec 100644
> --- a/drivers/mfd/cros_ec_spi.c
> +++ b/drivers/mfd/cros_ec_spi.c
> @@ -708,6 +708,7 @@ static SIMPLE_DEV_PM_OPS(cros_ec_spi_pm_ops, cros_ec_spi_suspend,
>                          cros_ec_spi_resume);
>
>  static const struct of_device_id cros_ec_spi_of_match[] = {
> +       { .compatible = "ni,cros-ec-spi", },

I am confused: if the 2 controllers are the same, why do we need the
new compat string, at least in the driver? Shouldn't DTS simply use
"google,cros-ec-spi", or maybe both (compatible = "ni,cros-ec-spi",
"google,cros-ec-spi")?

DT folks, is there clear instructions somewhere as to when
introduction of new compatible is warranted, along with the rules of
how to settle on common fallback (i.e. how to make sure that, let's
say, Linux, U-boot and FreeBSD use the same fallback compatible for
the same series of devices)?

>         { .compatible = "google,cros-ec-spi", },
>         { /* sentinel */ },
>  };
> --
> 2.7.4
>

Thanks.

-- 
Dmitry

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] Docs: DT: Add National Instruments vendor prefix Moritz Fischer <moritz.fischer@ettus.com> - 2016-09-28 19:10 +0200
  [PATCH 3/3] mfd: cros_ec_spi: Add compatible string for NI version of cros-ec-spi Moritz Fischer <moritz.fischer@ettus.com> - 2016-09-28 19:10 +0200
    Re: [PATCH 3/3] mfd: cros_ec_spi: Add compatible string for NI  version of cros-ec-spi Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-09-28 19:30 +0200
      Re: [PATCH 3/3] mfd: cros_ec_spi: Add compatible string for NI  version of cros-ec-spi Moritz Fischer <moritz.fischer@ettus.com> - 2016-09-28 19:40 +0200
  Re: [PATCH 1/3] Docs: DT: Add National Instruments vendor prefix Rob Herring <robh@kernel.org> - 2016-10-04 15:30 +0200

csiph-web