Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1493407 > unrolled thread

Re: [PATCH v2 2/8] pipe: move limit checking logic into pipe_set_size()

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2 2/8] pipe: move limit checking logic into  pipe_set_size() Vegard Nossum <vegard.nossum@oracle.com> - 2016-09-29 13:30 +0200
    Re: [PATCH v2 2/8] pipe: move limit checking logic into  pipe_set_size() Joe Perches <joe@perches.com> - 2016-09-29 17:10 +0200

#1493407 — Re: [PATCH v2 2/8] pipe: move limit checking logic into pipe_set_size()

On 08/29/2016 02:21 AM, Michael Kerrisk (man-pages) wrote:
> This is a preparatory patch for following work. Move the F_SETPIPE_SZ
> limit-checking logic from pipe_fcntl() into pipe_set_size().  This
> simplifies the code a little, and allows for reworking required in
> a later patch that fixes the limit checking in pipe_set_size()

> +	if ((too_many_pipe_buffers_hard(pipe->user) ||
> +			too_many_pipe_buffers_soft(pipe->user)) &&
> +			!capable(CAP_SYS_RESOURCE) && !capable(CAP_SYS_ADMIN))
> +		return -EPERM;

Some might say the indentation is off here. Not sure why checkpatch
didn't care.

Otherwise looks fine to me.


Vegard

[toc] | [next] | [standalone]

#1493532

On Thu, 2016-09-29 at 13:26 +0200, Vegard Nossum wrote:
> On 08/29/2016 02:21 AM, Michael Kerrisk (man-pages) wrote:
> > This is a preparatory patch for following work. Move the F_SETPIPE_SZ
> > limit-checking logic from pipe_fcntl() into pipe_set_size().  This
> > simplifies the code a little, and allows for reworking required in
> > a later patch that fixes the limit checking in pipe_set_size()
> 
> > +	if ((too_many_pipe_buffers_hard(pipe->user) ||
> > +			too_many_pipe_buffers_soft(pipe->user)) &&
> > +			capable(CAP_SYS_RESOURCE) && !capable(CAP_SYS_ADMIN))
> > +		return -EPERM;
> Some might say the indentation is off here. Not sure why checkpatch
> didn't care.

Parenthesis alignment is a CHECK not a WARNING.

It's only reported with --strict or if the code is
in drivers/staging, net/, or drivers/net/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web