Re: [PATCH v2 2/8] pipe: move limit checking logic into pipe_set_size()

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/8] pipe: move limit checking logic into pipe_set_size()
Date	2016-09-29 17:10 +0200
Message-ID	<smL8d-5IG-9@gated-at.bofh.it> (permalink)
References	<sbiCB-eG-9@gated-at.bofh.it> <sbiCB-eG-17@gated-at.bofh.it> <smHHk-3tO-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 2016-09-29 at 13:26 +0200, Vegard Nossum wrote:
> On 08/29/2016 02:21 AM, Michael Kerrisk (man-pages) wrote:
> > This is a preparatory patch for following work. Move the F_SETPIPE_SZ
> > limit-checking logic from pipe_fcntl() into pipe_set_size().  This
> > simplifies the code a little, and allows for reworking required in
> > a later patch that fixes the limit checking in pipe_set_size()
> 
> > +	if ((too_many_pipe_buffers_hard(pipe->user) ||
> > +			too_many_pipe_buffers_soft(pipe->user)) &&
> > +			capable(CAP_SYS_RESOURCE) && !capable(CAP_SYS_ADMIN))
> > +		return -EPERM;
> Some might say the indentation is off here. Not sure why checkpatch
> didn't care.

Parenthesis alignment is a CHECK not a WARNING.

It's only reported with --strict or if the code is
in drivers/staging, net/, or drivers/net/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 2/8] pipe: move limit checking logic into  pipe_set_size() Vegard Nossum <vegard.nossum@oracle.com> - 2016-09-29 13:30 +0200
  Re: [PATCH v2 2/8] pipe: move limit checking logic into  pipe_set_size() Joe Perches <joe@perches.com> - 2016-09-29 17:10 +0200

csiph-web