Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1491573 > unrolled thread

Re: [PATCH v2] Net Driver: Add Cypress GX3 VID=04b4 PID=3610.

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2] Net Driver: Add Cypress GX3 VID=04b4 PID=3610. Chris Roth <chris.roth@usask.ca> - 2016-09-27 00:00 +0200
    Re: [PATCH v2] Net Driver: Add Cypress GX3 VID=04b4 PID=3610. Greg KH <gregkh@linuxfoundation.org> - 2016-09-27 17:50 +0200

#1491573 — Re: [PATCH v2] Net Driver: Add Cypress GX3 VID=04b4 PID=3610.

I'm not sure what I'm doing wrong:

I'm trying to get the from statement to read original author (Allan
Chou) first, and then me (Chris Roth) second. I've used the following
two commands:

git format-patch -o /tmp/ --subject-prefix="PATCH v2" --from="Allan
Chou <allan@asix.com.tw>" HEAD^

and

git send-email --to linux-usb@vger.kernel.org --to
netdev@vger.kernel.org --to linux-kernel@vger.kernel.org --from="Allan
Chou <allan@asix.com.tw>"
/tmp/0001-Net-Driver-Add-Cypress-GX3-VID-04b4-PID-3610.patch

I thought that adding the --from portions to the git format-patch and
git send-email commands would force the addition of Allan to the top
of the patch, but it hasn't. Can anyone tell me specifically how I
need to change these commands in order to get the desired result? Then
I'll submit a PATCH v3.

Regards,
Chris

On Mon, Sep 26, 2016 at 3:48 PM, Allan Chou <allan@asix.com.tw> wrote:
> From: Chris Roth <chris.roth@usask.ca>
>
> Add support for Cypress GX3 SuperSpeed to Gigabit Ethernet
> Bridge Controller (Vendor=04b4 ProdID=3610).
>
> Patch verified on x64 linux kernel 4.7.4 system with the
> Kensington SD4600P USB-C Universal Dock with Power, which uses the
> Cypress GX3 SuperSpeed to Gigabit Ethernet Bridge Controller.
>
> A similar patch was signed-off and tested-by Allan Chou
> <allan@asix.com.tw> on 2015-12-01.
>
> Allan verified his similar patch on x86 Linux kernel 4.1.6 system
> with Cypress GX3 SuperSpeed to Gigabit Ethernet Bridge Controller.
>
> Tested-by: Allan Chou <allan@asix.com.tw>
> Tested-by: Chris Roth <chris.roth@usask.ca>
>
> Signed-off-by: Allan Chou <allan@asix.com.tw>
> Signed-off-by: Chris Roth <chris.roth@usask.ca>
> ---
>  drivers/net/usb/ax88179_178a.c | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>
> diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c
> index e6338c1..8a6675d 100644
> --- a/drivers/net/usb/ax88179_178a.c
> +++ b/drivers/net/usb/ax88179_178a.c
> @@ -1656,6 +1656,19 @@ static const struct driver_info ax88178a_info = {
>         .tx_fixup = ax88179_tx_fixup,
>  };
>
> +static const struct driver_info cypress_GX3_info = {
> +       .description = "Cypress GX3 SuperSpeed to Gigabit Ethernet Controller",
> +       .bind = ax88179_bind,
> +       .unbind = ax88179_unbind,
> +       .status = ax88179_status,
> +       .link_reset = ax88179_link_reset,
> +       .reset = ax88179_reset,
> +       .stop = ax88179_stop,
> +       .flags = FLAG_ETHER | FLAG_FRAMING_AX,
> +       .rx_fixup = ax88179_rx_fixup,
> +       .tx_fixup = ax88179_tx_fixup,
> +};
> +
>  static const struct driver_info dlink_dub1312_info = {
>         .description = "D-Link DUB-1312 USB 3.0 to Gigabit Ethernet Adapter",
>         .bind = ax88179_bind,
> @@ -1718,6 +1731,10 @@ static const struct usb_device_id products[] = {
>         USB_DEVICE(0x0b95, 0x178a),
>         .driver_info = (unsigned long)&ax88178a_info,
>  }, {
> +       /* Cypress GX3 SuperSpeed to Gigabit Ethernet Bridge Controller */
> +       USB_DEVICE(0x04b4, 0x3610),
> +       .driver_info = (unsigned long)&cypress_GX3_info,
> +}, {
>         /* D-Link DUB-1312 USB 3.0 to Gigabit Ethernet Adapter */
>         USB_DEVICE(0x2001, 0x4a00),
>         .driver_info = (unsigned long)&dlink_dub1312_info,
> --
> 2.7.4
>

[toc] | [next] | [standalone]

#1491987

On Mon, Sep 26, 2016 at 03:56:59PM -0600, Chris Roth wrote:
> I'm not sure what I'm doing wrong:
> 
> I'm trying to get the from statement to read original author (Allan
> Chou) first, and then me (Chris Roth) second. I've used the following
> two commands:
> 
> git format-patch -o /tmp/ --subject-prefix="PATCH v2" --from="Allan
> Chou <allan@asix.com.tw>" HEAD^
> 
> and
> 
> git send-email --to linux-usb@vger.kernel.org --to
> netdev@vger.kernel.org --to linux-kernel@vger.kernel.org --from="Allan
> Chou <allan@asix.com.tw>"
> /tmp/0001-Net-Driver-Add-Cypress-GX3-VID-04b4-PID-3610.patch
> 
> I thought that adding the --from portions to the git format-patch and
> git send-email commands would force the addition of Allan to the top
> of the patch, but it hasn't. Can anyone tell me specifically how I
> need to change these commands in order to get the desired result? Then
> I'll submit a PATCH v3.

Take the patch that you have, hand-edit it with your favorite editor to
have the correct headers and signed-off-by and other fields, and then
use git send-email without the --from line, and you should be fine.

thanks,

greg k-h

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web