Groups > linux.kernel > #1491987

Re: [PATCH v2] Net Driver: Add Cypress GX3 VID=04b4 PID=3610.

From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] Net Driver: Add Cypress GX3 VID=04b4 PID=3610.
Date	2016-09-27 17:50 +0200
Message-ID	<sm2NP-2OB-1@gated-at.bofh.it> (permalink)
References	<slM6l-JE-9@gated-at.bofh.it> <slM6l-JE-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Sep 26, 2016 at 03:56:59PM -0600, Chris Roth wrote:
> I'm not sure what I'm doing wrong:
> 
> I'm trying to get the from statement to read original author (Allan
> Chou) first, and then me (Chris Roth) second. I've used the following
> two commands:
> 
> git format-patch -o /tmp/ --subject-prefix="PATCH v2" --from="Allan
> Chou <allan@asix.com.tw>" HEAD^
> 
> and
> 
> git send-email --to linux-usb@vger.kernel.org --to
> netdev@vger.kernel.org --to linux-kernel@vger.kernel.org --from="Allan
> Chou <allan@asix.com.tw>"
> /tmp/0001-Net-Driver-Add-Cypress-GX3-VID-04b4-PID-3610.patch
> 
> I thought that adding the --from portions to the git format-patch and
> git send-email commands would force the addition of Allan to the top
> of the patch, but it hasn't. Can anyone tell me specifically how I
> need to change these commands in order to get the desired result? Then
> I'll submit a PATCH v3.

Take the patch that you have, hand-edit it with your favorite editor to
have the correct headers and signed-off-by and other fields, and then
use git send-email without the --from line, and you should be fine.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] Net Driver: Add Cypress GX3 VID=04b4 PID=3610. Chris Roth <chris.roth@usask.ca> - 2016-09-27 00:00 +0200
  Re: [PATCH v2] Net Driver: Add Cypress GX3 VID=04b4 PID=3610. Greg KH <gregkh@linuxfoundation.org> - 2016-09-27 17:50 +0200

csiph-web