Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1490924 > unrolled thread

[PATCH -next] staging: most: fix error return code in audio_probe_channel()

Started byWei Yongjun <weiyj.lk@gmail.com>
First post2016-09-25 17:50 +0200
Last post2016-09-26 11:00 +0200
Articles 4 — 4 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH -next] staging: most: fix error return code in audio_probe_channel() Wei Yongjun <weiyj.lk@gmail.com> - 2016-09-25 17:50 +0200
    Re: [PATCH -next] staging: most: fix error return code in  audio_probe_channel() Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-25 19:30 +0200
    Re: [PATCH -next] staging: most: fix error return code in  audio_probe_channel() Andrey Shvetsov <andrey.shvetsov@k2l.de> - 2016-09-26 09:50 +0200
      Re: [PATCH -next] staging: most: fix error return code in  audio_probe_channel() Christian Gromm <christian.gromm@microchip.com> - 2016-09-26 11:00 +0200

#1490924 — [PATCH -next] staging: most: fix error return code in audio_probe_channel()

FromWei Yongjun <weiyj.lk@gmail.com>
Date2016-09-25 17:50 +0200
Subject[PATCH -next] staging: most: fix error return code in audio_probe_channel()
Message-ID<sljQJ-8or-1@gated-at.bofh.it>
From: Wei Yongjun <weiyongjun1@huawei.com>

Fix to return a negative error code from the audio_set_hw_params() error
handling case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/staging/most/aim-sound/sound.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/most/aim-sound/sound.c b/drivers/staging/most/aim-sound/sound.c
index 3dc625c..00f01c9 100644
--- a/drivers/staging/most/aim-sound/sound.c
+++ b/drivers/staging/most/aim-sound/sound.c
@@ -607,7 +607,8 @@ static int audio_probe_channel(struct most_interface *iface, int channel_id,
 	channel->id = channel_id;
 	init_waitqueue_head(&channel->playback_waitq);
 
-	if (audio_set_hw_params(&channel->pcm_hardware, pcm_format, cfg))
+	ret = audio_set_hw_params(&channel->pcm_hardware, pcm_format, cfg);
+	if (ret)
 		goto err_free_card;
 
 	snprintf(card->driver, sizeof(card->driver), "%s", DRIVER_NAME);

[toc] | [next] | [standalone]

#1490938 — Re: [PATCH -next] staging: most: fix error return code in audio_probe_channel()

FromGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Date2016-09-25 19:30 +0200
SubjectRe: [PATCH -next] staging: most: fix error return code in audio_probe_channel()
Message-ID<sllpv-10M-7@gated-at.bofh.it>
In reply to#1490924
On Sun, Sep 25, 2016 at 03:41:11PM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
> 
> Fix to return a negative error code from the audio_set_hw_params() error
> handling case instead of 0, as done elsewhere in this function.
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
>  drivers/staging/most/aim-sound/sound.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/most/aim-sound/sound.c b/drivers/staging/most/aim-sound/sound.c
> index 3dc625c..00f01c9 100644
> --- a/drivers/staging/most/aim-sound/sound.c
> +++ b/drivers/staging/most/aim-sound/sound.c
> @@ -607,7 +607,8 @@ static int audio_probe_channel(struct most_interface *iface, int channel_id,
>  	channel->id = channel_id;
>  	init_waitqueue_head(&channel->playback_waitq);
>  
> -	if (audio_set_hw_params(&channel->pcm_hardware, pcm_format, cfg))
> +	ret = audio_set_hw_params(&channel->pcm_hardware, pcm_format, cfg);
> +	if (ret)
>  		goto err_free_card;

Are you sure you want that error value?  I need an ack from the driver
maintainers before I can take this...

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1491124 — Re: [PATCH -next] staging: most: fix error return code in audio_probe_channel()

FromAndrey Shvetsov <andrey.shvetsov@k2l.de>
Date2016-09-26 09:50 +0200
SubjectRe: [PATCH -next] staging: most: fix error return code in audio_probe_channel()
Message-ID<slyPL-112-9@gated-at.bofh.it>
In reply to#1490924
On Sun, Sep 25, 2016 at 03:41:11PM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
> 
> Fix to return a negative error code from the audio_set_hw_params() error
> handling case instead of 0, as done elsewhere in this function.
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Andrey Shvetsov <andrey.shvetsov@k2l.de>

> ---
>  drivers/staging/most/aim-sound/sound.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/most/aim-sound/sound.c b/drivers/staging/most/aim-sound/sound.c
> index 3dc625c..00f01c9 100644
> --- a/drivers/staging/most/aim-sound/sound.c
> +++ b/drivers/staging/most/aim-sound/sound.c
> @@ -607,7 +607,8 @@ static int audio_probe_channel(struct most_interface *iface, int channel_id,
>  	channel->id = channel_id;
>  	init_waitqueue_head(&channel->playback_waitq);
>  
> -	if (audio_set_hw_params(&channel->pcm_hardware, pcm_format, cfg))
> +	ret = audio_set_hw_params(&channel->pcm_hardware, pcm_format, cfg);
> +	if (ret)
>  		goto err_free_card;
>  
>  	snprintf(card->driver, sizeof(card->driver), "%s", DRIVER_NAME);
>

[toc] | [prev] | [next] | [standalone]

#1491162 — Re: [PATCH -next] staging: most: fix error return code in audio_probe_channel()

FromChristian Gromm <christian.gromm@microchip.com>
Date2016-09-26 11:00 +0200
SubjectRe: [PATCH -next] staging: most: fix error return code in audio_probe_channel()
Message-ID<slzVv-1EX-31@gated-at.bofh.it>
In reply to#1491124
On Mon, 26 Sep 2016 09:47:19 +0200
Andrey Shvetsov <andrey.shvetsov@k2l.de> wrote:

> On Sun, Sep 25, 2016 at 03:41:11PM +0000, Wei Yongjun wrote:
> > From: Wei Yongjun <weiyongjun1@huawei.com>
> > 
> > Fix to return a negative error code from the audio_set_hw_params() error
> > handling case instead of 0, as done elsewhere in this function.
> > 
> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> Signed-off-by: Andrey Shvetsov <andrey.shvetsov@k2l.de>

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>

> 
> > ---
> >  drivers/staging/most/aim-sound/sound.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/most/aim-sound/sound.c b/drivers/staging/most/aim-sound/sound.c
> > index 3dc625c..00f01c9 100644
> > --- a/drivers/staging/most/aim-sound/sound.c
> > +++ b/drivers/staging/most/aim-sound/sound.c
> > @@ -607,7 +607,8 @@ static int audio_probe_channel(struct most_interface *iface, int channel_id,
> >  	channel->id = channel_id;
> >  	init_waitqueue_head(&channel->playback_waitq);
> >  
> > -	if (audio_set_hw_params(&channel->pcm_hardware, pcm_format, cfg))
> > +	ret = audio_set_hw_params(&channel->pcm_hardware, pcm_format, cfg);
> > +	if (ret)
> >  		goto err_free_card;
> >  
> >  	snprintf(card->driver, sizeof(card->driver), "%s", DRIVER_NAME);
> > 
>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web