[PATCH -next] staging: most: fix error return code in audio_probe_channel()

From	Wei Yongjun <weiyj.lk@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH -next] staging: most: fix error return code in audio_probe_channel()
Date	2016-09-25 17:50 +0200
Message-ID	<sljQJ-8or-1@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Wei Yongjun <weiyongjun1@huawei.com>

Fix to return a negative error code from the audio_set_hw_params() error
handling case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/staging/most/aim-sound/sound.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/most/aim-sound/sound.c b/drivers/staging/most/aim-sound/sound.c
index 3dc625c..00f01c9 100644
--- a/drivers/staging/most/aim-sound/sound.c
+++ b/drivers/staging/most/aim-sound/sound.c
@@ -607,7 +607,8 @@ static int audio_probe_channel(struct most_interface *iface, int channel_id,
 	channel->id = channel_id;
 	init_waitqueue_head(&channel->playback_waitq);
 
-	if (audio_set_hw_params(&channel->pcm_hardware, pcm_format, cfg))
+	ret = audio_set_hw_params(&channel->pcm_hardware, pcm_format, cfg);
+	if (ret)
 		goto err_free_card;
 
 	snprintf(card->driver, sizeof(card->driver), "%s", DRIVER_NAME);

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH -next] staging: most: fix error return code in audio_probe_channel() Wei Yongjun <weiyj.lk@gmail.com> - 2016-09-25 17:50 +0200
  Re: [PATCH -next] staging: most: fix error return code in  audio_probe_channel() Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-25 19:30 +0200
  Re: [PATCH -next] staging: most: fix error return code in  audio_probe_channel() Andrey Shvetsov <andrey.shvetsov@k2l.de> - 2016-09-26 09:50 +0200
    Re: [PATCH -next] staging: most: fix error return code in  audio_probe_channel() Christian Gromm <christian.gromm@microchip.com> - 2016-09-26 11:00 +0200

csiph-web