Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1490169 > unrolled thread

[PATCH] kcov: do not instrument lib/stackdepot.c

Started byAlexander Potapenko <glider@google.com>
First post2016-09-23 16:30 +0200
Last post2016-09-23 16:40 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] kcov: do not instrument lib/stackdepot.c Alexander Potapenko <glider@google.com> - 2016-09-23 16:30 +0200
    Re: [PATCH] kcov: do not instrument lib/stackdepot.c Dmitry Vyukov <dvyukov@google.com> - 2016-09-23 16:40 +0200

#1490169 — [PATCH] kcov: do not instrument lib/stackdepot.c

FromAlexander Potapenko <glider@google.com>
Date2016-09-23 16:30 +0200
Subject[PATCH] kcov: do not instrument lib/stackdepot.c
Message-ID<skzEe-4NF-19@gated-at.bofh.it>
There's no point in collecting coverage from lib/stackdepot.c, as it is
not a function of syscall inputs. Disabling kcov instrumentation for
that file will reduce the coverage noise level.

Signed-off-by: Alexander Potapenko <glider@google.com>
---
 lib/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/Makefile b/lib/Makefile
index 5dc77a8..cbac596 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -180,6 +180,7 @@ obj-$(CONFIG_IRQ_POLL) += irq_poll.o
 
 obj-$(CONFIG_STACKDEPOT) += stackdepot.o
 KASAN_SANITIZE_stackdepot.o := n
+KCOV_INSTRUMENT_stackdepot.o := n
 
 libfdt_files = fdt.o fdt_ro.o fdt_wip.o fdt_rw.o fdt_sw.o fdt_strerror.o \
 	       fdt_empty_tree.o
-- 
2.8.0.rc3.226.g39d4020

[toc] | [next] | [standalone]


#1490178

FromDmitry Vyukov <dvyukov@google.com>
Date2016-09-23 16:40 +0200
Message-ID<skzNT-4QO-33@gated-at.bofh.it>
In reply to#1490169
On Fri, Sep 23, 2016 at 4:29 PM, Alexander Potapenko <glider@google.com> wrote:
> There's no point in collecting coverage from lib/stackdepot.c, as it is
> not a function of syscall inputs. Disabling kcov instrumentation for
> that file will reduce the coverage noise level.
>
> Signed-off-by: Alexander Potapenko <glider@google.com>

Acked-by: Dmitry Vyukov <dvyukov@google.com>


> ---
>  lib/Makefile | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lib/Makefile b/lib/Makefile
> index 5dc77a8..cbac596 100644
> --- a/lib/Makefile
> +++ b/lib/Makefile
> @@ -180,6 +180,7 @@ obj-$(CONFIG_IRQ_POLL) += irq_poll.o
>
>  obj-$(CONFIG_STACKDEPOT) += stackdepot.o
>  KASAN_SANITIZE_stackdepot.o := n
> +KCOV_INSTRUMENT_stackdepot.o := n
>
>  libfdt_files = fdt.o fdt_ro.o fdt_wip.o fdt_rw.o fdt_sw.o fdt_strerror.o \
>                fdt_empty_tree.o
> --
> 2.8.0.rc3.226.g39d4020
>

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web