Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1490178

Re: [PATCH] kcov: do not instrument lib/stackdepot.c

From Dmitry Vyukov <dvyukov@google.com>
Newsgroups linux.kernel
Subject Re: [PATCH] kcov: do not instrument lib/stackdepot.c
Date 2016-09-23 16:40 +0200
Message-ID <skzNT-4QO-33@gated-at.bofh.it> (permalink)
References <skzEe-4NF-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, Sep 23, 2016 at 4:29 PM, Alexander Potapenko <glider@google.com> wrote:
> There's no point in collecting coverage from lib/stackdepot.c, as it is
> not a function of syscall inputs. Disabling kcov instrumentation for
> that file will reduce the coverage noise level.
>
> Signed-off-by: Alexander Potapenko <glider@google.com>

Acked-by: Dmitry Vyukov <dvyukov@google.com>


> ---
>  lib/Makefile | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lib/Makefile b/lib/Makefile
> index 5dc77a8..cbac596 100644
> --- a/lib/Makefile
> +++ b/lib/Makefile
> @@ -180,6 +180,7 @@ obj-$(CONFIG_IRQ_POLL) += irq_poll.o
>
>  obj-$(CONFIG_STACKDEPOT) += stackdepot.o
>  KASAN_SANITIZE_stackdepot.o := n
> +KCOV_INSTRUMENT_stackdepot.o := n
>
>  libfdt_files = fdt.o fdt_ro.o fdt_wip.o fdt_rw.o fdt_sw.o fdt_strerror.o \
>                fdt_empty_tree.o
> --
> 2.8.0.rc3.226.g39d4020
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH] kcov: do not instrument lib/stackdepot.c Alexander Potapenko <glider@google.com> - 2016-09-23 16:30 +0200
  Re: [PATCH] kcov: do not instrument lib/stackdepot.c Dmitry Vyukov <dvyukov@google.com> - 2016-09-23 16:40 +0200

csiph-web