Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1489066 > unrolled thread

[PATCH v3 2/2] staging: ion: Fix a coding style issue

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH v3 2/2] staging: ion: Fix a coding style issue Antti Keränen <detegr@gmail.com> - 2016-09-22 18:10 +0200
    Re: [PATCH v3 2/2] staging: ion: Fix a coding style issue Laura Abbott <labbott@redhat.com> - 2016-09-22 22:30 +0200
      [PATCH v4] staging: ion: Fix a coding style issue Antti Keränen <detegr@gmail.com> - 2016-09-23 20:10 +0200
        Re: [PATCH v4] staging: ion: Fix a coding style issue Laura Abbott <labbott@redhat.com> - 2016-09-23 22:40 +0200

#1489066 — [PATCH v3 2/2] staging: ion: Fix a coding style issue

Correctly align an unaligned block comment

Signed-off-by: Antti Keränen <detegr@gmail.com>
---
 drivers/staging/android/uapi/ion.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h
index 647f130..e629394 100644
--- a/drivers/staging/android/uapi/ion.h
+++ b/drivers/staging/android/uapi/ion.h
@@ -57,7 +57,7 @@ enum ion_heap_type {
 					 * cached, ion will do cache
 					 * maintenance when the buffer is
 					 * mapped for dma
-					*/
+					 */
 #define ION_FLAG_CACHED_NEEDS_SYNC 2	/*
 					 * mappings of this buffer will created
 					 * at mmap time, if this is set
-- 
2.9.3

[toc] | [next] | [standalone]

#1489525

On 09/22/2016 08:59 AM, Antti Keränen wrote:
> Correctly align an unaligned block comment
>
> Signed-off-by: Antti Keränen <detegr@gmail.com>
> ---
>  drivers/staging/android/uapi/ion.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h
> index 647f130..e629394 100644
> --- a/drivers/staging/android/uapi/ion.h
> +++ b/drivers/staging/android/uapi/ion.h
> @@ -57,7 +57,7 @@ enum ion_heap_type {
>  					 * cached, ion will do cache
>  					 * maintenance when the buffer is
>  					 * mapped for dma
> -					*/
> +					 */
>  #define ION_FLAG_CACHED_NEEDS_SYNC 2	/*
>  					 * mappings of this buffer will created
>  					 * at mmap time, if this is set
>

I've always hated these comments. Can you fix them to be regular
looking right above each #define?

Thanks,
Laura

[toc] | [prev] | [next] | [standalone]

#1490367 — [PATCH v4] staging: ion: Fix a coding style issue

This patch fixes the alignment of an allocation flag block comment
and moves the comments before each #define.

Signed-off-by: Antti Keränen <detegr@gmail.com>
---
In addition to fixing the alignment issue, this version of the patch moves
the comments from after the define lines to before the define lines.

 drivers/staging/android/uapi/ion.h | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h
index 647f130..14cd873 100644
--- a/drivers/staging/android/uapi/ion.h
+++ b/drivers/staging/android/uapi/ion.h
@@ -52,18 +52,18 @@ enum ion_heap_type {
  * allocation flags - the lower 16 bits are used by core ion, the upper 16
  * bits are reserved for use by the heaps themselves.
  */
-#define ION_FLAG_CACHED 1		/*
-					 * mappings of this buffer should be
-					 * cached, ion will do cache
-					 * maintenance when the buffer is
-					 * mapped for dma
-					*/
-#define ION_FLAG_CACHED_NEEDS_SYNC 2	/*
-					 * mappings of this buffer will created
-					 * at mmap time, if this is set
-					 * caches must be managed
-					 * manually
-					 */
+
+/*
+ * mappings of this buffer should be cached, ion will do cache maintenance
+ * when the buffer is mapped for dma
+ */
+#define ION_FLAG_CACHED 1
+
+/*
+ * mappings of this buffer will created at mmap time, if this is set
+ * caches must be managed manually
+ */
+#define ION_FLAG_CACHED_NEEDS_SYNC 2
 
 /**
  * DOC: Ion Userspace API
-- 
2.9.3

[toc] | [prev] | [next] | [standalone]

#1490446 — Re: [PATCH v4] staging: ion: Fix a coding style issue

On 09/23/2016 11:03 AM, Antti Keränen wrote:
> This patch fixes the alignment of an allocation flag block comment
> and moves the comments before each #define.
>

Acked-by: Laura Abbott <labbott@redhat.com>

> Signed-off-by: Antti Keränen <detegr@gmail.com>
> ---
> In addition to fixing the alignment issue, this version of the patch moves
> the comments from after the define lines to before the define lines.
>
>  drivers/staging/android/uapi/ion.h | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h
> index 647f130..14cd873 100644
> --- a/drivers/staging/android/uapi/ion.h
> +++ b/drivers/staging/android/uapi/ion.h
> @@ -52,18 +52,18 @@ enum ion_heap_type {
>   * allocation flags - the lower 16 bits are used by core ion, the upper 16
>   * bits are reserved for use by the heaps themselves.
>   */
> -#define ION_FLAG_CACHED 1		/*
> -					 * mappings of this buffer should be
> -					 * cached, ion will do cache
> -					 * maintenance when the buffer is
> -					 * mapped for dma
> -					*/
> -#define ION_FLAG_CACHED_NEEDS_SYNC 2	/*
> -					 * mappings of this buffer will created
> -					 * at mmap time, if this is set
> -					 * caches must be managed
> -					 * manually
> -					 */
> +
> +/*
> + * mappings of this buffer should be cached, ion will do cache maintenance
> + * when the buffer is mapped for dma
> + */
> +#define ION_FLAG_CACHED 1
> +
> +/*
> + * mappings of this buffer will created at mmap time, if this is set
> + * caches must be managed manually
> + */
> +#define ION_FLAG_CACHED_NEEDS_SYNC 2
>
>  /**
>   * DOC: Ion Userspace API
>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web