Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1490446
| From | Laura Abbott <labbott@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v4] staging: ion: Fix a coding style issue |
| Date | 2016-09-23 22:40 +0200 |
| Message-ID | <skFqi-6t-17@gated-at.bofh.it> (permalink) |
| References | <skiN3-2zX-21@gated-at.bofh.it> <skD57-7dw-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 09/23/2016 11:03 AM, Antti Keränen wrote:
> This patch fixes the alignment of an allocation flag block comment
> and moves the comments before each #define.
>
Acked-by: Laura Abbott <labbott@redhat.com>
> Signed-off-by: Antti Keränen <detegr@gmail.com>
> ---
> In addition to fixing the alignment issue, this version of the patch moves
> the comments from after the define lines to before the define lines.
>
> drivers/staging/android/uapi/ion.h | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h
> index 647f130..14cd873 100644
> --- a/drivers/staging/android/uapi/ion.h
> +++ b/drivers/staging/android/uapi/ion.h
> @@ -52,18 +52,18 @@ enum ion_heap_type {
> * allocation flags - the lower 16 bits are used by core ion, the upper 16
> * bits are reserved for use by the heaps themselves.
> */
> -#define ION_FLAG_CACHED 1 /*
> - * mappings of this buffer should be
> - * cached, ion will do cache
> - * maintenance when the buffer is
> - * mapped for dma
> - */
> -#define ION_FLAG_CACHED_NEEDS_SYNC 2 /*
> - * mappings of this buffer will created
> - * at mmap time, if this is set
> - * caches must be managed
> - * manually
> - */
> +
> +/*
> + * mappings of this buffer should be cached, ion will do cache maintenance
> + * when the buffer is mapped for dma
> + */
> +#define ION_FLAG_CACHED 1
> +
> +/*
> + * mappings of this buffer will created at mmap time, if this is set
> + * caches must be managed manually
> + */
> +#define ION_FLAG_CACHED_NEEDS_SYNC 2
>
> /**
> * DOC: Ion Userspace API
>
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH v3 2/2] staging: ion: Fix a coding style issue Antti Keränen <detegr@gmail.com> - 2016-09-22 18:10 +0200
Re: [PATCH v3 2/2] staging: ion: Fix a coding style issue Laura Abbott <labbott@redhat.com> - 2016-09-22 22:30 +0200
[PATCH v4] staging: ion: Fix a coding style issue Antti Keränen <detegr@gmail.com> - 2016-09-23 20:10 +0200
Re: [PATCH v4] staging: ion: Fix a coding style issue Laura Abbott <labbott@redhat.com> - 2016-09-23 22:40 +0200
csiph-web