Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1487060 > unrolled thread
| Started by | Rafał Miłecki <zajec5@gmail.com> |
|---|---|
| First post | 2016-09-20 07:20 +0200 |
| Last post | 2016-09-20 16:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v2 4/6] net: ethernet: bgmac: convert to feature flags Rafał Miłecki <zajec5@gmail.com> - 2016-09-20 07:20 +0200
Re: [PATCH v2 4/6] net: ethernet: bgmac: convert to feature flags Jon Mason <jon.mason@broadcom.com> - 2016-09-20 16:00 +0200
| From | Rafał Miłecki <zajec5@gmail.com> |
|---|---|
| Date | 2016-09-20 07:20 +0200 |
| Subject | Re: [PATCH v2 4/6] net: ethernet: bgmac: convert to feature flags |
| Message-ID | <sjlDk-7aN-3@gated-at.bofh.it> |
On 17 August 2016 at 13:34, Rafał Miłecki <zajec5@gmail.com> wrote: > On 8 July 2016 at 01:08, Jon Mason <jon.mason@broadcom.com> wrote: >> mode = (bgmac_read(bgmac, BGMAC_DEV_STATUS) & BGMAC_DS_MM_MASK) >> >> BGMAC_DS_MM_SHIFT; >> - if (ci->id != BCMA_CHIP_ID_BCM47162 || mode != 0) >> + if (bgmac->feature_flags & BGMAC_FEAT_CLKCTLST || mode != 0) >> bgmac_set(bgmac, BCMA_CLKCTLST, BCMA_CLKCTLST_FORCEHT); >> - if (ci->id == BCMA_CHIP_ID_BCM47162 && mode == 2) >> + if (bgmac->feature_flags & BGMAC_FEAT_CLKCTLST && mode == 2) >> bcma_chipco_chipctl_maskset(&bgmac->core->bus->drv_cc, 1, ~0, >> BGMAC_CHIPCTL_1_RXC_DLL_BYPASS); > > Jon, it looks to me you translated two following conditions: > ci->id != BCMA_CHIP_ID_BCM47162 > and > ci->id == BCMA_CHIP_ID_BCM47162 > into the same flag check: > bgmac->feature_flags & BGMAC_FEAT_CLKCTLST > > I don't think it's intentional, is it? Do you have a moment to fix this? Ping -- Rafał
[toc] | [next] | [standalone]
| From | Jon Mason <jon.mason@broadcom.com> |
|---|---|
| Date | 2016-09-20 16:00 +0200 |
| Message-ID | <sjtKy-3DJ-23@gated-at.bofh.it> |
| In reply to | #1487060 |
On Tue, Sep 20, 2016 at 1:19 AM, Rafał Miłecki <zajec5@gmail.com> wrote: > On 17 August 2016 at 13:34, Rafał Miłecki <zajec5@gmail.com> wrote: >> On 8 July 2016 at 01:08, Jon Mason <jon.mason@broadcom.com> wrote: >>> mode = (bgmac_read(bgmac, BGMAC_DEV_STATUS) & BGMAC_DS_MM_MASK) >> >>> BGMAC_DS_MM_SHIFT; >>> - if (ci->id != BCMA_CHIP_ID_BCM47162 || mode != 0) >>> + if (bgmac->feature_flags & BGMAC_FEAT_CLKCTLST || mode != 0) >>> bgmac_set(bgmac, BCMA_CLKCTLST, BCMA_CLKCTLST_FORCEHT); >>> - if (ci->id == BCMA_CHIP_ID_BCM47162 && mode == 2) >>> + if (bgmac->feature_flags & BGMAC_FEAT_CLKCTLST && mode == 2) >>> bcma_chipco_chipctl_maskset(&bgmac->core->bus->drv_cc, 1, ~0, >>> BGMAC_CHIPCTL_1_RXC_DLL_BYPASS); >> >> Jon, it looks to me you translated two following conditions: >> ci->id != BCMA_CHIP_ID_BCM47162 >> and >> ci->id == BCMA_CHIP_ID_BCM47162 >> into the same flag check: >> bgmac->feature_flags & BGMAC_FEAT_CLKCTLST >> >> I don't think it's intentional, is it? Do you have a moment to fix this? > > Ping Sorry, just seeing this now. I'll double check the original code and verify it (or fix it). Thanks, Jon > > -- > Rafał
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web