Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1487053 > unrolled thread
| Started by | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| First post | 2016-09-20 06:50 +0200 |
| Last post | 2016-09-20 12:50 +0200 |
| Articles | 5 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] ARM: uniphier: select ARCH_HAS_RESET_CONTROLLER Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-09-20 06:50 +0200
Re: [PATCH] ARM: uniphier: select ARCH_HAS_RESET_CONTROLLER Philipp Zabel <p.zabel@pengutronix.de> - 2016-09-20 09:40 +0200
Re: [PATCH] ARM: uniphier: select ARCH_HAS_RESET_CONTROLLER Philipp Zabel <p.zabel@pengutronix.de> - 2016-09-20 09:40 +0200
Re: [PATCH] ARM: uniphier: select ARCH_HAS_RESET_CONTROLLER Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-09-20 10:50 +0200
Re: [PATCH] ARM: uniphier: select ARCH_HAS_RESET_CONTROLLER Philipp Zabel <p.zabel@pengutronix.de> - 2016-09-20 12:50 +0200
| From | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| Date | 2016-09-20 06:50 +0200 |
| Subject | [PATCH] ARM: uniphier: select ARCH_HAS_RESET_CONTROLLER |
| Message-ID | <sjlah-6Le-3@gated-at.bofh.it> |
The UniPhier reset driver (drivers/reset/reset-uniphier.c) has been merged. Select ARCH_HAS_RESET_CONTROLLER from the SoC Kconfig. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- Philipp, IIRC, you mentioned that you were planning to consolidate the double gurad by CONFIG_RESET_CONTROLLER and CONFIG_ARCH_HAS_RESET_CONTROLLER. I have not seen it in the ML, so I am sending this. Please let me know if you have some updates. arch/arm/mach-uniphier/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-uniphier/Kconfig b/arch/arm/mach-uniphier/Kconfig index 82dddee..3930fbb 100644 --- a/arch/arm/mach-uniphier/Kconfig +++ b/arch/arm/mach-uniphier/Kconfig @@ -1,6 +1,7 @@ config ARCH_UNIPHIER bool "Socionext UniPhier SoCs" depends on ARCH_MULTI_V7 + select ARCH_HAS_RESET_CONTROLLER select ARM_AMBA select ARM_GLOBAL_TIMER select ARM_GIC -- 1.9.1
[toc] | [next] | [standalone]
| From | Philipp Zabel <p.zabel@pengutronix.de> |
|---|---|
| Date | 2016-09-20 09:40 +0200 |
| Message-ID | <sjnON-8o2-1@gated-at.bofh.it> |
| In reply to | #1487053 |
Am Dienstag, den 20.09.2016, 13:43 +0900 schrieb Masahiro Yamada: > The UniPhier reset driver (drivers/reset/reset-uniphier.c) has been > merged. Select ARCH_HAS_RESET_CONTROLLER from the SoC Kconfig. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Acked-by: Philipp Zabel <p.zabel@pengutronix.de> regards Philipp
[toc] | [prev] | [next] | [standalone]
| From | Philipp Zabel <p.zabel@pengutronix.de> |
|---|---|
| Date | 2016-09-20 09:40 +0200 |
| Message-ID | <sjnOO-8o2-27@gated-at.bofh.it> |
| In reply to | #1487053 |
Hi Masahiro,
Am Dienstag, den 20.09.2016, 13:43 +0900 schrieb Masahiro Yamada:
> The UniPhier reset driver (drivers/reset/reset-uniphier.c) has been
> merged. Select ARCH_HAS_RESET_CONTROLLER from the SoC Kconfig.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> Philipp,
>
> IIRC, you mentioned that you were planning to consolidate the double
> gurad by CONFIG_RESET_CONTROLLER and CONFIG_ARCH_HAS_RESET_CONTROLLER.
>
> I have not seen it in the ML, so I am sending this.
>
> Please let me know if you have some updates.
I had started to doodle a bit, see
git fetch git://git.pengutronix.de/git/pza/linux.git refs/heads/reset/kconfig
but I haven't found time for cleanup and testing.
regards
Philipp
[toc] | [prev] | [next] | [standalone]
| From | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| Date | 2016-09-20 10:50 +0200 |
| Message-ID | <sjoUy-Bu-19@gated-at.bofh.it> |
| In reply to | #1487121 |
Hi Philipp,
2016-09-20 16:30 GMT+09:00 Philipp Zabel <p.zabel@pengutronix.de>:
> Hi Masahiro,
>
> Am Dienstag, den 20.09.2016, 13:43 +0900 schrieb Masahiro Yamada:
>> The UniPhier reset driver (drivers/reset/reset-uniphier.c) has been
>> merged. Select ARCH_HAS_RESET_CONTROLLER from the SoC Kconfig.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>> ---
>>
>> Philipp,
>>
>> IIRC, you mentioned that you were planning to consolidate the double
>> gurad by CONFIG_RESET_CONTROLLER and CONFIG_ARCH_HAS_RESET_CONTROLLER.
>>
>> I have not seen it in the ML, so I am sending this.
>>
>> Please let me know if you have some updates.
>
> I had started to doodle a bit, see
>
> git fetch git://git.pengutronix.de/git/pza/linux.git refs/heads/reset/kconfig
>
> but I haven't found time for cleanup and testing.
OK, I will merge this patch for now.
BTW, I did not understand some of your commits under way.
commit 7fe911f9c83737449565db03bebf953d3d94bbbf
Author: Philipp Zabel <p.zabel@pengutronix.de>
Date: Tue Aug 9 11:18:51 2016 +0200
dmaengine: sunx6i: do not depend on reset controller framework
The reset controller framework provides inline function stubs if
disabled.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
As far as I see from drivers/dma/sun6i-dma.c,
the reset control is mandatory for this driver.
Why are you removing the dependency?
Don't you care if it works on run-time
as long as it can build?
--
Best Regards
Masahiro Yamada
[toc] | [prev] | [next] | [standalone]
| From | Philipp Zabel <p.zabel@pengutronix.de> |
|---|---|
| Date | 2016-09-20 12:50 +0200 |
| Message-ID | <sjqMG-1Q1-17@gated-at.bofh.it> |
| In reply to | #1487157 |
Am Dienstag, den 20.09.2016, 17:47 +0900 schrieb Masahiro Yamada: > Hi Philipp, > > > 2016-09-20 16:30 GMT+09:00 Philipp Zabel <p.zabel@pengutronix.de>: > > Hi Masahiro, > > > > Am Dienstag, den 20.09.2016, 13:43 +0900 schrieb Masahiro Yamada: > >> The UniPhier reset driver (drivers/reset/reset-uniphier.c) has been > >> merged. Select ARCH_HAS_RESET_CONTROLLER from the SoC Kconfig. > >> > >> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > >> --- > >> > >> Philipp, > >> > >> IIRC, you mentioned that you were planning to consolidate the double > >> gurad by CONFIG_RESET_CONTROLLER and CONFIG_ARCH_HAS_RESET_CONTROLLER. > >> > >> I have not seen it in the ML, so I am sending this. > >> > >> Please let me know if you have some updates. > > > > I had started to doodle a bit, see > > > > git fetch git://git.pengutronix.de/git/pza/linux.git refs/heads/reset/kconfig > > > > but I haven't found time for cleanup and testing. > > > OK, I will merge this patch for now. > > > > BTW, I did not understand some of your commits under way. > > > commit 7fe911f9c83737449565db03bebf953d3d94bbbf > Author: Philipp Zabel <p.zabel@pengutronix.de> > Date: Tue Aug 9 11:18:51 2016 +0200 > > dmaengine: sunx6i: do not depend on reset controller framework > > The reset controller framework provides inline function stubs if > disabled. > > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de> > > > > > > As far as I see from drivers/dma/sun6i-dma.c, > the reset control is mandatory for this driver. > > Why are you removing the dependency? > > > Don't you care if it works on run-time > as long as it can build? I have not thought about this too hard, it's just there because the reset framework is not a build dependency (anymore). Some patches were necessary to remove dependency loops, but I think this one could just be dropped. regards Philipp
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web